| Summary: | Missing --no-stop-on-failure option for the case when you have config file with `stop-on-failure true` | ||
|---|---|---|---|
| Product: | [Developer tools] kdesrc-build | Reporter: | Andrew Shark <ashark> |
| Component: | documentation | Assignee: | Michael Pyne <mpyne> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/sdk/kdesrc-build/-/commit/1860f30bf92298ead7d355c29ca5e91135d7a0e5 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Andrew Shark
2023-09-07 15:36:13 UTC
I have found out that I had `stop-on-failure true` in the `kdesrc-buildrc` file. But I did not changed that. After I change it to false, the kdesrc-build behaves as expected. I see, the FirstRun.pm module prepares a file with this option turned to true. https://invent.kde.org/sdk/kdesrc-build/-/blob/c0e1620d38e413bda66d6e759a1512975a6d413d/modules/ksb/FirstRun.pm#L1243 But [documentation for config file](https://docs.kde.org/trunk5/en/kdesrc-build/kdesrc-build/conf-options-table.html#conf-stop-on-failure) says > This option is off by default. In previous comment I was wrong, the [documentation for cli](https://docs.kde.org/trunk5/en/kdesrc-build/kdesrc-build/supported-cmdline-params.html#cmdline-stop-on-failure) does not assume anything. But still it lacks the opposite option `--no-stop-on-failure`. We need to either change the doc or change the value in code. My suggestion it to change value in code, because it is useful to not stop on failure. A possibly relevant merge request was started @ https://invent.kde.org/sdk/kdesrc-build/-/merge_requests/284 Git commit a49e8272602fb85474a352d4d4fa363711aaa70b by Nate Graham, on behalf of Andrew Shark. Committed on 11/09/2023 at 18:51. Pushed by ngraham into branch 'master'. Comply documentation for stop-on-failure conf option The [doc](https://docs.kde.org/trunk5/en/kdesrc-build/kdesrc-build/conf-options-table.html#conf-stop-on-failure) says it is off by default. M +1 -2 doc/index.docbook https://invent.kde.org/sdk/kdesrc-build/-/commit/a49e8272602fb85474a352d4d4fa363711aaa70b A possibly relevant merge request was started @ https://invent.kde.org/sdk/kdesrc-build/-/merge_requests/327 A quick tip for step 1 on how to intentionally break successfullness of some module building:
```kdesrc-buildrc
# intentionally break module
options kcolorscheme
custom-build-command bad
end options
```
Will fail with the message " * Unable to find the bad executable!".
Git commit c300de55cd6b4519192ab79800d8cf78e0d98bb1 by Joshua Goins, on behalf of Andrew Shark. Committed on 20/11/2023 at 17:03. Pushed by redstrate into branch 'master'. Indicate the existence of --no-stop-on-failure flag M +1 -5 README.md M +1 -1 completions/zsh/_kdesrc-build M +2 -2 doc/README.md M +11 -17 doc/index.docbook M +3 -8 doc/man-kdesrc-build.1.docbook M +0 -2 modules/ksb/Cmdline.pm https://invent.kde.org/sdk/kdesrc-build/-/commit/c300de55cd6b4519192ab79800d8cf78e0d98bb1 Git commit bd82b2f32eff7e4f53b1c45d81c89866164ee178 by Nate Graham, on behalf of Andrew Shark. Committed on 11/09/2023 at 16:51. Pushed by ashark into branch 'docbook_historied_per_file'. Comply documentation for stop-on-failure conf option The [doc](https://docs.kde.org/trunk5/en/kdesrc-build/kdesrc-build/conf-options-table.html#conf-stop-on-failure) says it is off by default. Original commit: a49e8272 https://invent.kde.org/sdk/kdesrc-build/-/commit/a49e8272602fb85474a352d4d4fa363711aaa70b M +1 -2 doc/kdesrc-buildrc/conf-options-table.docbook https://invent.kde.org/sdk/kdesrc-build/-/commit/bd82b2f32eff7e4f53b1c45d81c89866164ee178 Git commit 1860f30bf92298ead7d355c29ca5e91135d7a0e5 by Joshua Goins, on behalf of Andrew Shark. Committed on 20/11/2023 at 16:03. Pushed by ashark into branch 'docbook_historied_per_file'. Indicate the existence of --no-stop-on-failure flag Original commit: c300de55 https://invent.kde.org/sdk/kdesrc-build/-/commit/c300de55cd6b4519192ab79800d8cf78e0d98bb1 M +4 -10 doc/cmdline/supported-cmdline-params.docbook M +2 -2 doc/getting-started/building-and-troubleshooting.docbook M +2 -2 doc/kdesrc-buildrc/conf-options-table.docbook M +3 -3 doc/using-kdesrc-build/advanced-features.docbook https://invent.kde.org/sdk/kdesrc-build/-/commit/1860f30bf92298ead7d355c29ca5e91135d7a0e5 |