Bug 474253

Summary: Short slider(s) in certain KCMs
Product: [Frameworks and Libraries] frameworks-qqc2-desktop-style Reporter: Patrick Silva <bugseforuns>
Component: generalAssignee: ratijas <me>
Status: RESOLVED FIXED    
Severity: normal CC: ahiemstra, kde, nate, noahadvs, notmart
Priority: NOR Keywords: qt6, regression
Version: unspecified   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: General Behavior KCM
Mouse KCM
Touchpad KCM

Description Patrick Silva 2023-09-07 11:11:37 UTC
Created attachment 161489 [details]
General Behavior KCM

STEPS TO REPRODUCE
1. open any of these KCMs:
General Behavior
Mouse
Touchpad
2. 
3. 

OBSERVED RESULT
silder(s) shorter than normal. Please see the attached screenshots.

EXPECTED RESULT
normal slider(s)

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.27.80
KDE Frameworks Version: 5.240.0
Qt Version: 6.6.0
Graphics Platform: Wayland
Comment 1 Patrick Silva 2023-09-07 11:12:12 UTC
Created attachment 161490 [details]
Mouse KCM
Comment 2 Patrick Silva 2023-09-07 11:12:35 UTC
Created attachment 161491 [details]
Touchpad KCM
Comment 3 Nate Graham 2023-09-07 16:49:42 UTC
Can reproduce. Ivan, can you take a look?
Comment 4 ratijas 2023-09-07 17:15:08 UTC
In fact I was about to patch Mouse KCM.

Basically, the recent refactoring uncovered the fact that in certain places we relied on Slider's implicit size to be long enough. Obviously, this isn't going to work very well for variety of styles and interfaces. Just always set slider width, or stretch it to fill horizontal space.
Comment 6 ratijas 2023-09-08 20:54:01 UTC
Git commit fd0bd8ab20faa66e7437302c50866a368b4d2037 by ivan tkachenko.
Committed on 08/09/2023 at 22:47.
Pushed by ratijas into branch 'master'.

kcms/mouse,touchpad: Stretch Sliders horizontally

Don't rely on style's implicit side, it might be arbitrary, and is in
fact often too small.

M  +3    -0    kcms/mouse/kcm/libinput/main.qml
M  +1    -0    kcms/mouse/kcm/libinput/main_deviceless.qml
M  +4    -0    kcms/touchpad/kcm/libinput/touchpad.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/fd0bd8ab20faa66e7437302c50866a368b4d2037
Comment 7 ratijas 2023-09-08 23:26:08 UTC
Git commit 77bd54f855bb38d3f1c64844628b377c949e28d3 by ivan tkachenko.
Committed on 09/09/2023 at 01:25.
Pushed by ratijas into branch 'master'.

kcms/workspace: Stretch Slider horizontally

Don't rely on style's implicit side, it might be arbitrary, and is in
fact often too small.

M  +1    -0    kcms/workspaceoptions/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/77bd54f855bb38d3f1c64844628b377c949e28d3