Bug 474129

Summary: Restore previously selected side bar when closing git history view
Product: [Applications] kate Reporter: Markus Pister <info>
Component: generalAssignee: KWrite Developers <kwrite-bugs-null>
Status: VERIFIED FIXED    
Severity: normal CC: waqar.17a
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/utilities/kate/-/commit/da7a434df849ba4b2f0cbc7d07d7055a72b9497e Version Fixed/Implemented In:
Sentry Crash Report:

Description Markus Pister 2023-09-04 07:48:27 UTC 
SUMMARY
When closing the git history view of a file, the left sidebar is closed. Usually (at least in my workflow), there was a selected sidebar opened before starting to look at the git history, e.g. the project view from which the git history view was opened.
It would be very convenient, to restore the sidebar used before the git history view got opened.

STEPS TO REPRODUCE
1.  Open project view sidebar
2.  Use context menu "Show Git History" on an arbitrary file
3.  Hit close button of displayed git history sidebar

OBSERVED RESULT
No left sidebar is displayed, all are closed.

EXPECTED RESULT
The sidebar is opened that was used before hitting the "Show Git History" context menu entry.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Endeavour OS using KDE/Plasma (wayland)
KDE Plasma Version: 5.27.7
KDE Frameworks Version: 5.109.0
Qt Version: 5.15.10
Comment 1 Waqar Ahmed 2024-03-18 11:59:19 UTC 
Agreed, would be good to have.
Comment 2 Bug Janitor Service 2024-03-20 19:52:36 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/utilities/kate/-/merge_requests/1428
Comment 3 Christoph Cullmann 2024-03-20 20:13:56 UTC 
Git commit da7a434df849ba4b2f0cbc7d07d7055a72b9497e by Christoph Cullmann, on behalf of Waqar Ahmed.
Committed on 20/03/2024 at 20:10.
Pushed by cullmann into branch 'master'.

Restore last active toolview when closing file history

M  +9    -0    apps/lib/filehistorywidget.cpp
M  +5    -0    apps/lib/katemainwindow.h
M  +21   -0    apps/lib/katemdi.cpp
M  +13   -0    apps/lib/katemdi.h
M  +8    -0    apps/lib/ktexteditor_utils.cpp
M  +2    -0    apps/lib/ktexteditor_utils.h

https://invent.kde.org/utilities/kate/-/commit/da7a434df849ba4b2f0cbc7d07d7055a72b9497e
Comment 4 Markus Pister 2024-03-21 05:55:32 UTC 
Just checked the implemented behavior on a fresh master build. Works perfectly. Thanks for implementing this.