Bug 474043

Summary:	7896095c7694b96c8f4512bd0b050f864cf4cd75 breaks various icons and strings in Disks & Devices widget
Product:	[Plasma] plasmashell	Reporter:	Nate Graham <nate>
Component:	Disks & Devices widget	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	qt6, regression
Priority:	NOR
Version First Reported In:	master
Target Milestone:	1.0
Platform:	Other
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=474023
Latest Commit:	https://invent.kde.org/plasma/plasma-workspace/-/commit/b20231afc34a08d3d174bbdc0dfafbbfe94ba96e	Version Fixed In:
Sentry Crash Report:

Description Nate Graham 2023-09-01 23:53:37 UTC

The get() method of PlasmaCore.SortFilterModel was used in plasma-workspace/applets/devicenotifier/package/contents/ui/main.qml as well, causing these errors:

Sep 01 17:48:49 Liberator plasmashell[116532]: file:///home/nate/kde/usr6/share/plasma/plasmoids/org.kde.plasma.devicenotifier/contents/ui/main.qml:69: TypeError: Type error
Sep 01 17:48:49 Liberator plasmashell[116532]: file:///home/nate/kde/usr6/share/plasma/plasmoids/org.kde.plasma.devicenotifier/contents/ui/main.qml:56: TypeError: Type error
Sep 01 17:48:49 Liberator plasmashell[116532]: file:///home/nate/kde/usr6/share/plasma/plasmoids/org.kde.plasma.devicenotifier/contents/ui/main.qml:59: TypeError: Type error

This only breaks some strings and icons, nothing major, but it still needs to be fixed.

Comment 1 Bug Janitor Service 2023-09-10 00:17:43 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3274

Comment 2 ratijas 2023-09-12 14:12:34 UTC

Git commit b20231afc34a08d3d174bbdc0dfafbbfe94ba96e by ivan tkachenko.
Committed on 12/09/2023 at 16:03.
Pushed by ratijas into branch 'master'.

applets/devicenotifier: Fix fetching data from sort-filter model

Port to KRoleNames attached property to fix remaining incompatibilities
with the old sort-filter class in a nice and consistent way.

See https://invent.kde.org/frameworks/kitemmodels/-/merge_requests/77

M  +10   -10   applets/devicenotifier/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/b20231afc34a08d3d174bbdc0dfafbbfe94ba96e