Bug 473951

Summary:	Filelight does not honor directory exclusion list or filesystem boundary option
Product:	[Applications] filelight	Reporter:	J. Gerhards <g1.jasger>
Component:	general	Assignee:	fanzhuyifan
Status:	RESOLVED FIXED
Severity:	normal	CC:	fanzhuyifan, g1.jasger, martin.sandsmark, nate, owl-from-hogvarts, rulatir, sitter, travneff
Priority:	NOR
Version:	23.08.0
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://invent.kde.org/utilities/filelight/-/commit/10f1fbf077c4b65cf13b9899ebcab940c6654f1b	Version Fixed In:	23.08.2
Sentry Crash Report:

Description J. Gerhards 2023-08-30 15:36:19 UTC

SUMMARY

STEPS TO REPRODUCE
1. Start Filelight
2. Add a directory from the "Do not scan folders" list in the configuration
3. Start a scan

OBSERVED RESULT
Excluded directory is being scanned and shown in the result

EXPECTED RESULT
Excluded directory should not be scanned or included in the result

SOFTWARE/OS VERSIONS
Linux: Arch Linux 
Kernel: 6.4.12-arch1-1
KDE Plasma Version: 5.27.7
KDE Frameworks Version: 5.109.0
Qt Version: 5.15.10

ADDITIONAL INFORMATION
This bug also includes default folders removed from the exclusion list, not being scanned and the "Scan across file system boundaries" option being ignored.

Comment 1 Nate Graham 2023-08-30 20:07:11 UTC

Can reproduce. I added /home to the exclusion lists, started a scan of /, and it still scanned /home.

Comment 2 Szczepan Hołyszewski 2023-09-13 10:01:33 UTC

*** Bug 474479 has been marked as a duplicate of this bug. ***

Comment 3 Szczepan Hołyszewski 2023-09-13 10:48:24 UTC

While this bug is being fixed, please recommend an alternative utility that CAN, as opposed to CANNOT, help me find disk space hogs on a specific partition. Not having this functionality hurts me a lot: I have the root partition 95% filled and Filelight's report is useless without being able to limit the scan to the partition in question.

Comment 4 fanzhuyifan 2023-09-17 01:52:46 UTC

Can reproduce

Comment 5 fanzhuyifan 2023-09-17 03:22:09 UTC

Seems to be caused by this commit: https://invent.kde.org/utilities/filelight/-/commit/659a3e487cd1d1e5d573892d938233aa4f52202a

Comment 6 Szczepan Hołyszewski 2023-10-02 09:57:46 UTC

(In reply to fanzhuyifan from comment #5)
> Seems to be caused by this commit:
> https://invent.kde.org/utilities/filelight/-/commit/
> 659a3e487cd1d1e5d573892d938233aa4f52202a

I can understand how that commit breaks manual exclusions, but how does it break the filesystem boundary option?

Comment 7 Harald Sitter 2023-10-02 11:24:48 UTC

If you expand the code above you'll find that scanning across boundaries is implemented as part of the ignore set.

Comment 8 Andrew 2023-11-11 13:18:53 UTC

(In reply to Szczepan Hołyszewski from comment #3)
> While this bug is being fixed, please recommend an alternative utility

For those who still did not get the fix like me: I use also Baobab and K4dirstat currently

Comment 9 Nate Graham 2023-11-15 20:42:28 UTC

*** Bug 476983 has been marked as a duplicate of this bug. ***