Bug 473716

Summary: Incorrect coloring of nested $$() entries of Make files
Product: [Frameworks and Libraries] frameworks-syntax-highlighting Reporter: Marián Konček <koncek.marian>
Component: syntaxAssignee: KWrite Developers <kwrite-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: walter.von.entferndt
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/frameworks/syntax-highlighting/-/commit/dcb0ded3f59764f08bb1203df706e9373b5475d3 Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Example of incorrect coloring

Description Marián Konček 2023-08-24 09:06:08 UTC 
Created attachment 161153 [details]
Example of incorrect coloring

SUMMARY
Incorrect coloring of nested $$() entries of Make files.

STEPS TO REPRODUCE
1. Try to open this file in Kate / Kwrite
https://github.com/fedora-java/jurand/blob/663ff198e8478650b82f7f4d31f3c7663ee527c0/rules.mk#L19

OBSERVED RESULT
Nested entries like $$() are colored incorrectly (ending parenthesis has different color than the leading parenthesis.

EXPECTED RESULT
Parentheses should be colored consistently, i. e. $$ should be handled by the syntax parser.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Fedora KDE 38
(available in About System)
KDE Plasma Version: 5.27.6
KDE Frameworks Version: 5.108.0
Qt Version: 5.15.10

ADDITIONAL INFORMATION
Comment 1 Bug Janitor Service 2023-09-03 00:54:35 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/syntax-highlighting/-/merge_requests/530
Comment 2 Christoph Cullmann 2023-09-03 17:46:45 UTC 
Git commit dcb0ded3f59764f08bb1203df706e9373b5475d3 by Christoph Cullmann, on behalf of Jonathan Poelen.
Committed on 03/09/2023 at 19:46.
Pushed by cullmann into branch 'master'.

Makefile: fix parenthesis in call function

```make
$(call func,bla(bla)$(bla)(bla)bla)
 #          ~~~~~~~~  ~~~ ~~~~~~~~  FuncParam
 #                  ~~   ~        ~ Operator
```

M  +3    -0    autotests/folding/Makefile.fold
M  +3    -0    autotests/html/Makefile.dark.html
M  +3    -0    autotests/html/Makefile.html
M  +3    -0    autotests/input/Makefile
M  +3    -0    autotests/reference/Makefile.ref
M  +18   -5    data/syntax/makefile.xml

https://invent.kde.org/frameworks/syntax-highlighting/-/commit/dcb0ded3f59764f08bb1203df706e9373b5475d3