| Summary: | Can't use terminal tab while a diff is opened | ||
|---|---|---|---|
| Product: | [Applications] kdevelop | Reporter: | Jack Hill <jackhill3103> |
| Component: | VCS: Git | Assignee: | Igor Kushnir <igorkuo> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | igorkuo |
| Priority: | NOR | ||
| Version First Reported In: | 5.11.230403 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/kdevelop/kdevelop/-/commit/90331d9076dbf05cc094a00da3f314abe8e1db04 | Version Fixed/Implemented In: | 5.13.231200 |
| Sentry Crash Report: | |||
Indeed. The "garbage" error looks like another bug. Setting the actions' shortcut context to Qt::WidgetShortcut (but not Qt::WidgetWithChildrenShortcut, which KTextEditor view uses for all built-in actions) fixes this issue. I'll create a merge request with this fix soon. A possibly relevant merge request was started @ https://invent.kde.org/kdevelop/kdevelop/-/merge_requests/477 Git commit 90331d9076dbf05cc094a00da3f314abe8e1db04 by Igor Kushnir. Committed on 14/09/2023 at 11:01. Pushed by igorkushnir into branch 'master'. git: restrict diff views' shortcut context FIXED-IN: 5.13.231200 M +7 -0 plugins/git/diffviewsctrl.cpp https://invent.kde.org/kdevelop/kdevelop/-/commit/90331d9076dbf05cc094a00da3f314abe8e1db04 |
SUMMARY Seems like the VCS module is stealing keyboard control even though the terminal tab is active. (Maybe applies to all tabs - I haven't tested) STEPS TO REPRODUCE 1. Edit a file that is tracked by git 2. Open "Git Commit" tab (left sidebar) 3. Click on the edited file from this dock (should open the diff) 4. Open the terminal tab (bottom bar) 5. In the terminal press the letter "s" OBSERVED RESULT Nothing is entered into the terminal. Terminal tab is replaced with the "Version Control" tab with the following message: /home/jack/Dev/KDE6/src/elisa> git apply --index --cached /tmp/kdevelop.yDrhec Command exited with value 128. error: patch with only garbage at line 5 Command finished with error UnknownError. EXPECTED RESULT Letter "s" is entered into the terminal SOFTWARE/OS VERSIONS Operating System: openSUSE Tumbleweed 20230821 KDE Plasma Version: 5.27.7 KDE Frameworks Version: 5.109.0 Qt Version: 5.15.10 Kernel Version: 6.4.11-1-default (64-bit) Graphics Platform: X11 ADDITIONAL INFORMATION