Bug 473568

Summary: krunner not finding Firefox bookmarks
Product: [Plasma] krunner Reporter: isaac.o.braham
Component: bookmarksAssignee: Alexander Lohnau <alexander.lohnau>
Status: REPORTED ---    
Severity: normal CC: alexander.lohnau, natalie_clarius
Priority: NOR    
Version First Reported In: 5.27.6   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description isaac.o.braham 2023-08-20 17:21:02 UTC
SUMMARY
***
I can't seem to get krunner to show Firefox bookmarks.

I have tried;

setting and unsetting the bookmarks plugin
Plasma integration Firefox addon (with all settings ticked)
finding kdeglobals and making sure dbfile points to my Firefox profile
finding profiles.ini and making sure my Firefox profile is the default (it's also the only one)
restarting krunner
rebooting

Oddly krunner will show my Firefox history and tabs, but only when Firefox is actually open (even if minimised). With Firefox closed it shows nothing browser-related at all.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.27.6
KDE Frameworks Version: 5.108.0
Qt Version: 5.15.10

ADDITIONAL INFORMATION
Comment 1 Alexander Lohnau 2023-08-20 17:33:45 UTC
>finding kdeglobals and making sure dbfile points to my Firefox profile

Do you have those set explicitly?

>Oddly krunner will show my Firefox history and tabs, but only when Firefox is actually open (even if minimised)

Unlike the bookmarks runner, those use the browser APIs to get the open tabs/history. Meaning they are not related.

Could you try enabling debug output for the "Plasma Runner Bookmarks" category in kdebugsettings and run KRunner on the commandline using "krunner --replace"?

Also, which version of Firefox do you have installed and how did you install it?
Comment 2 isaac.o.braham 2023-08-21 16:24:12 UTC
(In reply to Alexander Lohnau from comment #1)
> >finding kdeglobals and making sure dbfile points to my Firefox profile
> 
> Do you have those set explicitly?

I'm not sure what you mean by 'explicitly'. I have a single profile at ``` /home/{me}/.mozilla/firefox/{profile}.default-release```, then in kdeglobals I edited the line to ```dbfile=/home/{me}/.mozilla/firefox/{profile}.default-release/places.sqlite```
(it used to have a different setting, presumably an old default profile which no longer exists)
 
> Could you try enabling debug output for the "Plasma Runner Bookmarks"
> category in kdebugsettings and run KRunner on the commandline using "krunner
> --replace"?

OK. I did that and krunner showed bookmarks. So I stopped krunner and started it again normally ```kstart5 krunner``` and it works!
Don't really understand what happened, but...

Whilst krunner is running from the terminal, I'm getting a load of...

```file:///usr/lib/qt/qml/org/kde/plasma/components.3/ToolTip.qml:57:9: QML Label: Binding loop detected for property "verticalAlignment"```
and
```Gtk-Message: 17:17:26.568: Failed to load module "appmenu-gtk-module"
[GFX1-]: vaapitest: ERROR
[GFX1-]: vaapitest: VA-API test failed: failed to initialise VAAPI connection.
```

...but as I say, the gui in plasma is now working fine, bookmarks and all, so...

> Also, which version of Firefox do you have installed and how did you install it?

In case it's still relevant - 115.0.2 installed from the repos with pacman.
Comment 3 Alexander Lohnau 2023-08-23 14:47:18 UTC
>Don't really understand what happened, but...

Weird, in the future, it might be worth looking at the DB files. Meaning what their modification timestamps are and if they are even valid.

>I'm not sure what you mean by 'explicitly'. I have a single profile at ``` /home/{me}/.mozilla/firefox/{profile}.default-release```, then in kdeglobals I edited the line to ```dbfile=/home/{me}/.mozilla/firefox/{profile}.default-release/places.sqlite```

Ah okay, I think the runner used to write this value automatically. IMHO you having an outdated value in there is reason to remove it (I never considered it useful TBH). Though I wonder: How did you even discover this? :D
Comment 4 Bug Janitor Service 2023-08-27 16:40:32 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3223
Comment 5 Alexander Lohnau 2023-09-17 19:27:49 UTC
Git commit 8be31b5cb408cb6be2cdf15ff9500af2162d9892 by Alexander Lohnau.
Committed on 17/09/2023 at 21:27.
Pushed by alex into branch 'master'.

runners/bookmarks: Do not read profile path from config file

This feature is nowhere documented. The key was written some Plasma
versions ago and people might have a stale entry because of it.

In any case, a magic entry in kdeglobals is not the way to go if we want
tho have the profile customizable.

M  +32   -41   runners/bookmarks/browsers/firefox.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/8be31b5cb408cb6be2cdf15ff9500af2162d9892