Bug 473510

Summary: Brush preset docker: tag list shows empty squares
Product: [Applications] krita Reporter: Takiro Ryo <takiro-kde>
Component: DockersAssignee: Dmitry Kazakov <dimula73>
Status: RESOLVED FIXED    
Severity: normal CC: dimula73, penguinflyer2222
Priority: NOR Keywords: regression, release_blocker
Version: 5.2.0-beta2   
Target Milestone: ---   
Platform: Manjaro   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Screenshot of the tag selection drop down

Description Takiro Ryo 2023-08-18 13:03:22 UTC
Created attachment 161047 [details]
Screenshot of the tag selection drop down

SUMMARY

Opening the list of tags by clicking on the tag/group selection shows an empty square in front of every tag/group name. 

STEPS TO REPRODUCE
1. Open Krita
2. Create a new document so the Brush Preset docker becomes usable
3. Click on the Tag select in the docker

OBSERVED RESULT
Every tag has an empty square in front of it.

EXPECTED RESULT
I'm honesty not sure what to expect but it isn't there in 5.1.5.
I first thought it's supposed to be a checkbox but I'm unable to interact with it in any meaningful way. 

Krita

 Version: 5.2.0-beta2
 Hidpi: true

Qt

  Version (compiled): 5.15.7
  Version (loaded): 5.15.7

OS Information

  Build ABI: x86_64-little_endian-lp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: linux
  Kernel Version: 6.4.9-1-MANJARO
  Pretty Productname: Manjaro Linux
  Product Type: manjaro
  Product Version: unknown
  Desktop: KDE
  Appimage build: Yes

Locale

  Languages: en_DE, en_Latn_DE
  C locale: C
  QLocale current: en-DE
  QLocale system: en-DE
  QTextCodec for locale: UTF-8

OpenGL Info
 
  Vendor:  "AMD" 
  Renderer:  "AMD Radeon RX 5700 XT (navi10, LLVM 15.0.7, DRM 3.52, 6.4.9-1-MANJARO)" 
  Driver version:  "4.6 (Core Profile) Mesa 23.1.5" 
  Shading language:  "4.60" 
  Requested format:  QSurfaceFormat(version 3.3, options QFlags<QSurfaceFormat::FormatOption>(), depthBufferSize 24, redBufferSize 8, greenBufferSize 8, blueBufferSize 8, alphaBufferSize 8, stencilBufferSize 8, samples -1, swapBehavior QSurfaceFormat::DoubleBuffer, swapInterval 0, colorSpace QSurfaceFormat::DefaultColorSpace, profile  QSurfaceFormat::CompatibilityProfile) 
  Current format:  QSurfaceFormat(version 4.6, options QFlags<QSurfaceFormat::FormatOption>(), depthBufferSize 24, redBufferSize 8, greenBufferSize 8, blueBufferSize 8, alphaBufferSize 8, stencilBufferSize 8, samples -1, swapBehavior QSurfaceFormat::DoubleBuffer, swapInterval 0, colorSpace QSurfaceFormat::DefaultColorSpace, profile  QSurfaceFormat::CoreProfile) 
  GL version: 4.6 
  Supports deprecated functions false 
  Is OpenGL ES: false 
  supportsBufferMapping: true 
  supportsBufferInvalidation: true 
  forceDisableTextureBuffers: false 
  Extensions: 
     GL_EXT_texture_integer 
     GL_ARB_texture_buffer_object_rgb32 
     GL_EXT_EGL_sync 
     GL_ARB_ES3_1_compatibility 
     GL_ARB_texture_compression_bptc 
     GL_AMD_query_buffer_object 
     GL_ARB_shader_bit_encoding 
     GL_EXT_texture_mirror_clamp 
     GL_AMD_vertex_shader_viewport_index 
     GL_ARB_point_sprite 
     GL_ARB_post_depth_coverage 
     GL_ARB_polygon_offset_clamp 
     GL_ARB_spirv_extensions 
     GL_ARB_fragment_shader 
     GL_ARB_texture_barrier 
     GL_ARB_shader_atomic_counter_ops 
     GL_ARB_texture_storage 
     GL_KHR_robustness 
     GL_ARB_vertex_attrib_binding 
     GL_NV_compute_shader_derivatives 
     GL_ARB_ES3_2_compatibility 
     GL_ARB_vertex_attrib_64bit 
     GL_NVX_gpu_memory_info 
     GL_IBM_multimode_draw_arrays 
     GL_ARB_ES3_compatibility 
     GL_EXT_packed_float 
     GL_EXT_texture_shadow_lod 
     GL_ARB_texture_multisample 
     GL_ARB_shader_storage_buffer_object 
     GL_S3_s3tc 
     GL_EXT_texture_array 
     GL_ARB_program_interface_query 
     GL_EXT_texture_compression_s3tc 
     GL_ARB_texture_compression_rgtc 
     GL_ARB_texture_query_lod 
     GL_ARB_vertex_type_2_10_10_10_rev 
     GL_AMD_framebuffer_multisample_advanced 
     GL_ARB_base_instance 
     GL_ARB_transform_feedback_instanced 
     GL_ARB_occlusion_query2 
     GL_EXT_semaphore_fd 
     GL_KHR_texture_compression_astc_sliced_3d 
     GL_NV_packed_depth_stencil 
     GL_ARB_texture_buffer_range 
     GL_NV_conditional_render 
     GL_AMD_conservative_depth 
     GL_AMD_performance_monitor 
     GL_KHR_debug 
     GL_ARB_explicit_uniform_location 
     GL_ARB_instanced_arrays 
     GL_AMD_multi_draw_indirect 
     GL_EXT_texture_sRGB_decode 
     GL_ARB_pixel_buffer_object 
     GL_ARB_gpu_shader_int64 
     GL_ARB_multi_bind 
     GL_EXT_texture_sRGB_R8 
     GL_ARB_shader_subroutine 
     GL_ARB_provoking_vertex 
     GL_ARB_robust_buffer_access_behavior 
     GL_AMD_shader_stencil_export 
     GL_EXT_debug_label 
     GL_ANGLE_texture_compression_dxt3 
     GL_ARB_shader_objects 
     GL_NV_depth_clamp 
     GL_ANGLE_texture_compression_dxt5 
     GL_INTEL_blackhole_render 
     GL_ARB_bindless_texture 
     GL_ARB_draw_buffers 
     GL_ARB_internalformat_query 
     GL_ARB_invalidate_subdata 
     GL_ARB_get_program_binary 
     GL_EXT_framebuffer_multisample 
     GL_ARB_vertex_shader 
     GL_ARB_texture_storage_multisample 
     GL_ARB_clip_control 
     GL_ARB_query_buffer_object 
     GL_ARB_shader_texture_lod 
     GL_ARB_clear_texture 
     GL_EXT_framebuffer_sRGB 
     GL_EXT_texture_sRGB_RG8 
     GL_ARB_draw_indirect 
     GL_AMD_texture_texture4 
     GL_ARB_transform_feedback2 
     GL_KHR_no_error 
     GL_ARB_texture_cube_map_array 
     GL_NV_vdpau_interop 
     GL_ARB_sparse_texture_clamp 
     GL_EXT_draw_buffers2 
     GL_EXT_window_rectangles 
     GL_ARB_explicit_attrib_location 
     GL_ARB_compressed_texture_pixel_storage 
     GL_EXT_provoking_vertex 
     GL_EXT_transform_feedback 
     GL_ARB_transform_feedback_overflow_query 
     GL_ARB_map_buffer_alignment 
     GL_MESA_framebuffer_flip_y 
     GL_ARB_uniform_buffer_object 
     GL_ARB_vertex_buffer_object 
     GL_ARB_texture_rgb10_a2ui 
     GL_EXT_draw_instanced 
     GL_ARB_pipeline_statistics_query 
     GL_ARB_arrays_of_arrays 
     GL_EXT_shader_image_load_formatted 
     GL_EXT_texture_compression_dxt1 
     GL_ARB_sparse_texture2 
     GL_ARB_shader_precision 
     GL_MESA_shader_integer_functions 
     GL_EXT_texture_compression_rgtc 
     GL_ATI_blend_equation_separate 
     GL_ARB_depth_buffer_float 
     GL_ARB_vertex_array_object 
     GL_ARB_enhanced_layouts 
     GL_ARB_color_buffer_float 
     GL_ARB_ES2_compatibility 
     GL_ARB_texture_stencil8 
     GL_ARB_seamless_cubemap_per_texture 
     GL_EXT_polygon_offset_clamp 
     GL_EXT_texture_filter_anisotropic 
     GL_EXT_depth_bounds_test 
     GL_ARB_texture_buffer_object 
     GL_ARB_tessellation_shader 
     GL_ARB_shader_image_load_store 
     GL_ARB_cull_distance 
     GL_EXT_texture_shared_exponent 
     GL_ARB_gpu_shader5 
     GL_ARB_robustness 
     GL_EXT_texture_snorm 
     GL_ARB_framebuffer_sRGB 
     GL_ARB_draw_buffers_blend 
     GL_EXT_framebuffer_blit 
     GL_AMD_draw_buffers_blend 
     GL_ARB_viewport_array 
     GL_EXT_timer_query 
     GL_ARB_shading_language_include 
     GL_NV_alpha_to_coverage_dither_control 
     GL_ARB_shader_group_vote 
     GL_EXT_vertex_attrib_64bit 
     GL_ARB_texture_rg 
     GL_ARB_transform_feedback3 
     GL_EXT_memory_object 
     GL_ARB_sparse_texture 
     GL_ARB_clear_buffer_object 
     GL_AMD_depth_clamp_separate 
     GL_ARB_fragment_coord_conventions 
     GL_AMD_gpu_shader_int64 
     GL_ARB_direct_state_access 
     GL_ARB_texture_non_power_of_two 
     GL_ARB_shader_stencil_export 
     GL_ARB_texture_mirror_clamp_to_edge 
     GL_ARB_separate_shader_objects 
     GL_ARB_shader_atomic_counters 
     GL_EXT_EGL_image_storage 
     GL_EXT_shader_samples_identical 
     GL_ARB_timer_query 
     GL_ARB_shader_draw_parameters 
     GL_ATI_texture_float 
     GL_ARB_shading_language_420pack 
     GL_KHR_robust_buffer_access_behavior 
     GL_ARB_conservative_depth 
     GL_KHR_context_flush_control 
     GL_ARB_multi_draw_indirect 
     GL_EXT_framebuffer_object 
     GL_KHR_blend_equation_advanced 
     GL_ARB_indirect_parameters 
     GL_EXT_shader_image_load_store 
     GL_ARB_compute_variable_group_size 
     GL_ARB_vertex_type_10f_11f_11f_rev 
     GL_ARB_conditional_render_inverted 
     GL_KHR_texture_compression_astc_ldr 
     GL_AMD_pinned_memory 
     GL_ARB_stencil_texturing 
     GL_EXT_shader_integer_mix 
     GL_EXT_vertex_array_bgra 
     GL_ARB_texture_query_levels 
     GL_EXT_demote_to_helper_invocation 
     GL_EXT_framebuffer_multisample_blit_scaled 
     GL_EXT_packed_depth_stencil 
     GL_ARB_shading_language_packing 
     GL_ARB_seamless_cube_map 
     GL_ARB_shader_clock 
     GL_ARB_sampler_objects 
     GL_EXT_semaphore 
     GL_AMD_shader_trinary_minmax 
     GL_ARB_shader_viewport_layer_array 
     GL_ARB_half_float_pixel 
     GL_ARB_parallel_shader_compile 
     GL_MESA_pack_invert 
     GL_MESA_texture_signed_rgba 
     GL_ARB_buffer_storage 
     GL_ARB_compute_shader 
     GL_ARB_internalformat_query2 
     GL_ARB_blend_func_extended 
     GL_ARB_copy_image 
     GL_ARB_texture_filter_anisotropic 
     GL_ARB_fragment_layer_viewport 
     GL_ARB_vertex_array_bgra 
     GL_ARB_debug_output 
     GL_ARB_map_buffer_range 
     GL_OES_EGL_image 
     GL_EXT_texture_swizzle 
     GL_ARB_framebuffer_no_attachments 
     GL_ARB_texture_gather 
     GL_ARB_texture_swizzle 
     GL_ARB_draw_instanced 
     GL_ARB_copy_buffer 
     GL_ARB_texture_view 
     GL_NV_shader_atomic_int64 
     GL_NV_texture_barrier 
     GL_EXT_texture_sRGB 
     GL_ARB_sync 
     GL_ARB_depth_clamp 
     GL_ARB_get_texture_sub_image 
     GL_ATI_texture_mirror_once 
     GL_ARB_draw_elements_base_vertex 
     GL_KHR_parallel_shader_compile 
     GL_ARB_derivative_control 
     GL_ARB_framebuffer_object 
     GL_ARB_sparse_buffer 
     GL_EXT_blend_equation_separate 
     GL_EXT_pixel_buffer_object 
     GL_NV_copy_image 
     GL_ARB_half_float_vertex 
     GL_ARB_texture_rectangle 
     GL_ARB_sample_shading 
     GL_ARB_shader_image_size 
     GL_ARB_shader_ballot 
     GL_AMD_vertex_shader_layer 
     GL_ARB_shader_texture_image_samples 
     GL_ARB_texture_float 
     GL_ATI_meminfo 
     GL_ARB_gpu_shader_fp64 
     GL_EXT_memory_object_fd 
     GL_ARB_gl_spirv 
     GL_AMD_seamless_cubemap_per_texture 
     GL_EXT_abgr 

QPA OpenGL Detection Info 
  supportsDesktopGL: true 
  supportsOpenGLES: true 
  isQtPreferOpenGLES: false 
  Detected renderers: 
    (Supported) AMD Radeon RX 5700 XT (navi10, LLVM 15.0.7, DRM 3.52, 6.4.9-1-MANJARO) (4.6 (Core Profile) Mesa 23.1.5) 
    (Supported) AMD Radeon RX 5700 XT (navi10, LLVM 15.0.7, DRM 3.52, 6.4.9-1-MANJARO) (OpenGL ES 3.2 Mesa 23.1.5)  

useBufferInvalidation (config option): false


Hardware Information

  GPU Acceleration: auto
  Memory: 32004 Mb
  Number of Cores: 24
  Swap Location: /tmp
  Built for: sse2
  Base instruction set: fma3+avx2
  Supported instruction sets: fma3+avx2 avx2 fma3+avx avx fma4 fma3+sse4.2 sse4.2 sse4.1 ssse3 sse3 sse2 

Current Settings

  Current Swap Location: /tmp
  Current Swap Location writable: true
  Undo Enabled: true
  Undo Stack Limit: 1000
  Use OpenGL: true
  Use OpenGL Texture Buffer: true
  Disable Vector Optimizations: false
  Disable AVX Optimizations: false
  Canvas State: OPENGL_SUCCESS
  Autosave Interval: 360
  Use Backup Files: true
  Number of Backups Kept: 1
  Backup File Suffix: ~
  Backup Location: Same Folder as the File
  Backup Location writable: false
  Resource Location: /home/takiro/.local/share/krita
  Use Win8 Pointer Input: false
  Use RightMiddleTabletButton Workaround: false
  Levels of Detail Enabled: false
  Use Zip64: false


Loaded Python Plugins
	colorspace
	comics_project_management_tools
	documenttools
	exportlayers
	filtermanager
	lastdocumentsdocker
	plugin_importer
	quick_settings_docker
	scripter
	tenbrushes
	tenscripts


Display Information
Number of screens: 3
	Screen: 0
		Name: DisplayPort-1
		Depth: 24
		Scale: 1.25
		Physical DPI87.11
		Logical DPI96
		Physical Size: 597, 336
		Position: 0, 720
		Resolution in pixels: 2048x1152
		Manufacturer: AOC
		Model: AG273QS3R4
		Refresh Rate: 143.912
		Serial Number: 63
	Screen: 1
		Name: DisplayPort-0
		Depth: 24
		Scale: 1.25
		Physical DPI130.665
		Logical DPI96
		Physical Size: 597, 336
		Position: 2560, 0
		Resolution in pixels: 3072x1728
		Manufacturer: BNQ
		Model: BenQ PD2700U
		Refresh Rate: 59.9966
		Serial Number: ETS3L00462SL0
	Screen: 2
		Name: DisplayPort-2
		Depth: 24
		Scale: 1.25
		Physical DPI149.64
		Logical DPI96
		Physical Size: 522, 293
		Position: 6400, 0
		Resolution in pixels: 3072x1728
		Manufacturer: Wacom Tech
		Model: CintiqPro24P
		Refresh Rate: 59.9966
		Serial Number: 9AH00F1000317
Comment 1 Freya Lupen 2023-08-18 13:36:39 UTC
It seems to have been introduced with the Qt update somehow (introduced between January 06 (19d3f9243b) Nightly and January 13 (5d138703f8) Nightly). Confirming as a regression.
Comment 2 Dmitry Kazakov 2023-08-21 14:53:27 UTC
Git commit ef90f573b4219549377ef94498b42941d6d04afc by Dmitry Kazakov.
Committed on 21/08/2023 at 16:53.
Pushed by dkazakov into branch 'master'.

Fix tag selector not to show the checkboxes next to each tag

We shouldn't use Qt::CheckStateRole, we have a special 'Active'
role for that.
Related: bug 440337

M  +5    -8    libs/resources/KisTagModel.cpp

https://invent.kde.org/graphics/krita/-/commit/ef90f573b4219549377ef94498b42941d6d04afc
Comment 3 Dmitry Kazakov 2023-08-21 14:55:49 UTC
Git commit c35dd06f895e89019f5b195af2a826bdc0f8c25d by Dmitry Kazakov.
Committed on 21/08/2023 at 16:55.
Pushed by dkazakov into branch 'krita/5.2'.

[for 5.2 only] Simplified fix for tag selector and checkboxes problem

Doing the full (and correct) refactoring might be a bit too risky
for the upcoming release.

M  +0    -3    libs/resources/KisTagModel.cpp

https://invent.kde.org/graphics/krita/-/commit/c35dd06f895e89019f5b195af2a826bdc0f8c25d