Bug 473467

Summary:	After changing the wallpaper plugin, the settings are not saved if I click OK directly
Product:	[Plasma] plasmashell	Reporter:	Fushan Wen <qydwhotmail>
Component:	Containment	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	notmart
Priority:	NOR	Keywords:	qt6, regression
Version First Reported In:	master
Target Milestone:	1.0
Platform:	Arch Linux
OS:	Other
Latest Commit:	https://invent.kde.org/plasma/plasma-desktop/-/commit/2cf107751d8737aa29a6dc485cd0459a6ae0366b	Version Fixed/Implemented In:
Sentry Crash Report:

Description Fushan Wen 2023-08-17 02:50:35 UTC

SUMMARY
The wallpaper config dialog fails to save modified settings.


STEPS TO REPRODUCE
1. Switch to Plain Color plugin
2. Set a custom color
3. Click OK

OBSERVED RESULT
Custom color is not saved

EXPECTED RESULT
Custom color is saved

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: plasma-workspace at 5d8049e4ef6f96844f1ab129f7ea85ebdfcd44f7
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 Bug Janitor Service 2023-08-17 10:49:21 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3192

Comment 2 Bug Janitor Service 2023-08-17 10:49:40 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1670

Comment 3 Fushan Wen 2023-08-21 15:37:56 UTC

Git commit 6bd568c2531af7e040ba109488613dc91c830172 by Fushan Wen.
Committed on 21/08/2023 at 17:29.
Pushed by fusionfuture into branch 'master'.

ContainmentConfigView: write config before syncing config object

Otherwise the new wallpaper config is not saved.

M  +1    -3    shell/containmentconfigview.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/6bd568c2531af7e040ba109488613dc91c830172

Comment 4 Fushan Wen 2023-08-21 15:39:36 UTC

Git commit 2cf107751d8737aa29a6dc485cd0459a6ae0366b by Fushan Wen.
Committed on 21/08/2023 at 17:39.
Pushed by fusionfuture into branch 'master'.

desktoppackage: set current wallpaper before writing config entries

In setCurrentWallpaper, `wallpaperConfiguration` can be recreated if the
newly selected wallpaper plugin is different to the current wallpaper plugin,
so currentWallpaper must be set before writing config entries.

M  +1    -1    desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/2cf107751d8737aa29a6dc485cd0459a6ae0366b