Bug 473459

Summary:	Line Tool produces wobbly lines
Product:	[Applications] krita	Reporter:	Freya Lupen <penguinflyer2222>
Component:	Tools	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dimula73, tgdev001
Priority:	NOR	Keywords:	regression, release_blocker
Version:	5.2.0-beta2
Target Milestone:	---
Platform:	Other
OS:	Other
Latest Commit:	https://invent.kde.org/graphics/krita/-/commit/1af06cbd8e48602b80c8da564a8db9d213000ac3	Version Fixed In:
Sentry Crash Report:
Attachments:	wobbly lines with Line Tool

Description Freya Lupen 2023-08-16 17:16:20 UTC

Created attachment 161010 [details]
wobbly lines with Line Tool

SUMMARY
As reported on KA (https://krita-artists.org/t/first-beta-for-krita-5-2-0-released-please-help-by-testing-and-reporting-bugs/71139/75), the Line Tool's lines are sometimes wobbly as if some of the dabs are misplaced along the line.
This doesn't appear to happen in 5.1.5, but I can reproduce it as far back as 5.2.0-prealpha-2264a44bec (October 12 Nightly build), the oldest one I have around to test.

STEPS TO REPRODUCE
1. Use the Line Tool to make diagonal lines.

OBSERVED RESULT
Not quite straight lines.

EXPECTED RESULT
Straight lines.

SOFTWARE/OS VERSIONS
Krita 5.2.0-beta2

ADDITIONAL INFORMATION
Attached image was made using 'b) Basic-1' brush at 10px size.

Comment 1 Dmitry Kazakov 2023-08-18 11:54:31 UTC

Git commit f4934e2177863e519130a34381439ec38b085962 by Dmitry Kazakov.
Committed on 18/08/2023 at 13:54.
Pushed by dkazakov into branch 'krita/5.2'.

Fix wobbly lines when using line tool

DDA adjustment should happen only when we use tiny brushes

M  +0    -1    plugins/tools/basictools/kis_tool_line_helper.cpp

https://invent.kde.org/graphics/krita/-/commit/f4934e2177863e519130a34381439ec38b085962

Comment 2 Dmitry Kazakov 2023-08-18 11:54:57 UTC

Git commit 1af06cbd8e48602b80c8da564a8db9d213000ac3 by Dmitry Kazakov.
Committed on 18/08/2023 at 13:54.
Pushed by dkazakov into branch 'master'.

Fix wobbly lines when using line tool

DDA adjustment should happen only when we use tiny brushes

M  +0    -1    plugins/tools/basictools/kis_tool_line_helper.cpp

https://invent.kde.org/graphics/krita/-/commit/1af06cbd8e48602b80c8da564a8db9d213000ac3