Bug 473420

Summary: With "fill free space on panel" disabled, task manager items do not shrink when panel is full, causing overflow
Product: [Plasma] plasmashell Reporter: Natalie Clarius <natalie_clarius>
Component: Task Manager and Icons-Only Task ManagerAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED DUPLICATE    
Severity: normal CC: nate, niccolo, qydwhotmail
Priority: NOR    
Version: master   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Task items not shrinking
Look at the top panel

Description Natalie Clarius 2023-08-15 14:16:04 UTC
Created attachment 160986 [details]
Task items not shrinking

SUMMARY
***
When the panel gets full, items in the classical task manager no longer shrink, causing the panel contents to overflow.
***

STEPS TO REPRODUCE
1. Have the (icons + text) task manager in the panel
2. Open many windows

OBSERVED RESULT
Tasks shrink to accommodate more items

EXPECTED RESULT
Tasks stay the same size, causing panel items to go out of space

SOFTWARE/OS VERSIONS
Plasma git master
Qt Version: 6.5.1
Comment 1 Nate Graham 2023-08-16 21:50:07 UTC
Can reproduce!
Comment 2 Nate Graham 2023-08-16 21:58:08 UTC
Do you know if this broke recently, or has it been broken since you started using Plasma 6?
Comment 3 Natalie Clarius 2023-08-17 07:35:55 UTC
I don't know. I think only recently but can't tell for sure.
Comment 4 Nate Graham 2023-09-08 14:01:41 UTC
*** Bug 472859 has been marked as a duplicate of this bug. ***
Comment 5 Niccolò Venerandi 2023-09-09 08:40:57 UTC
I cannot reproduce on master :-/
Comment 6 Nate Graham 2023-09-09 14:52:50 UTC
Are you using Qt 6.6? Maybe it's fixed there?

If not, make sure you are testing with a traditional task manager on a horizontal panel, with many open windows.
Comment 7 Niccolò Venerandi 2023-09-09 23:01:29 UTC
(In reply to Nate Graham from comment #6)
> Are you using Qt 6.6? Maybe it's fixed there?

Qt 6.5.2 :-/

> 
> If not, make sure you are testing with a traditional task manager on a
> horizontal panel, with many open windows.

Yep, that's what I've done. I tested both with different applications, and multiple instance of the same application with grouping off. Also tried different panel sizes. No luck
Comment 8 Nate Graham 2023-09-11 16:40:32 UTC
I'm using Qt 6.5.2 as well and can reproduce it with these exact steps:

1. Right-click on desktop > Add Panel > Empty Panel. Change no settings.
2. Right-click on that empty Panel > Add Widgets
2. Add a Task Manager widget to it
3. Open enough windows that it fills up
Comment 9 Natalie Clarius 2023-09-13 15:23:22 UTC
I just noticed it's actually a problem on stable Plasma too.
Comment 10 Nate Graham 2023-09-13 15:34:21 UTC
Eek, raising priority, then.
Comment 11 Natalie Clarius 2023-09-13 15:37:40 UTC
Centering still works though, so I don't think that's the same bug after all.
Comment 12 Natalie Clarius 2023-09-13 15:48:59 UTC
If it's of any use, I get it on both Arch and Tuxedo OS (Ubuntu based), and while I don't have as many windows open to fill the panel all that often, it can't be longer than a month or so ago.
Comment 13 Natalie Clarius 2023-09-13 15:49:47 UTC
(What I mean is that a couple weeks ago it was not yet broken)
Comment 14 Bug Janitor Service 2023-09-18 13:56:45 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1726
Comment 15 Natalie Clarius 2023-09-18 23:18:21 UTC
For me the bug occurs with a top panel but not a bottom one.  

It doesn't change depending on whether or not I have spacers on the sides.
Comment 16 Nate Graham 2023-09-19 16:07:17 UTC
I'm no longer able to reproduce this issue with today's git master using the exact steps I mentioned in Comment 8, even with a top Panel as Natalie mentioned.
Comment 17 Nate Graham 2023-09-19 18:35:04 UTC
To clarify, I'm unable to reproduce it in Plasma 6. Are you able to reproduce it in Plasma 6, Natalie, or only Plasma 5?
Comment 18 Natalie Clarius 2023-09-19 23:09:56 UTC
Plasma 6.

Okay, I was wrong, it's not the panel position that makes a difference but the arrangement of widgets on it. Still haven't yet figured out what it is; it's not the spacers.

Try this panel layout: clock - system tray - flexible spacer - non-grouped text task manager - flexible spacer - desktop pager

Can you reproduce it now?
Comment 19 Nate Graham 2023-09-20 17:29:47 UTC
When you say "non-grouped text task manager", do you mean:
- Traditional Task Manager
- Traditional Task Manager with grouping manually disabled
- Icons-Only Task Manager with grouping manually disabled

Because all three are "non-grouped", for certain definitions of the term. :)
Comment 20 Natalie Clarius 2023-09-20 20:46:45 UTC
I mean Traditional Task Manager with grouping manually disabled. Just what's visible in the screenshot in the first post
Comment 21 Marco Martin 2023-09-21 07:48:57 UTC
Git commit 03c41ae57620ef539e7bfc19a9191fb93c5ddbd9 by Marco Martin.
Committed on 21/09/2023 at 09:48.
Pushed by mart into branch 'master'.

applets/taskmanager: Use a Grid instead of a Flow

It's not possible to ensure that a flow won't attempt to put an item
on a new line. This causes more relayouts and the effect of a newly
open task flying over from a phantom new line.
Related: bug 396616
FIXED-IN: 6.0

M  +3    -3    applets/taskmanager/package/contents/ui/TaskList.qml
M  +2    -2    applets/taskmanager/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/03c41ae57620ef539e7bfc19a9191fb93c5ddbd9
Comment 22 Nate Graham 2023-09-21 15:30:29 UTC
(In reply to Natalie Clarius from comment #20)
> I mean Traditional Task Manager with grouping manually disabled. Just what's
> visible in the screenshot in the first post

I thought so, but I wanted to be sure. In fact I just tested the exact thing you suggested in order to reproduce Bug 472859. And I was able to reproduce the issue described there, but not the one here.
Comment 23 Natalie Clarius 2023-09-21 15:35:14 UTC
And neither on stable nor on master?
Comment 24 Nate Graham 2023-09-21 15:38:48 UTC
It was on master; haven't tested stable yet. Who has time for that junky old Plasma 5 thing? :D
Comment 25 Natalie Clarius 2023-09-21 15:42:04 UTC
Someone who isn't quite brave enough to daily-drive the future ™ yet :)

I'll do some more testing to see if I can find out under what conditions exactly I can get this bug.
Comment 26 Nate Graham 2023-09-21 21:00:44 UTC
Created attachment 161789 [details]
Look at the top panel

I gave it a try in Plasma 5.27.8 on X11 with the exact set of widgets you specified, on an empty top panel. I unchecked the two grouping-related checkboxes in the Task Manager settings; other than that, everything is vanilla with default settings.

I cannot reproduce the issue and am attaching a screenshot showing my panel with tons of windows, and they're shrinking as expected rather than overflowing.
Comment 27 Nate Graham 2023-09-21 21:09:36 UTC
At this point I'd recommend trying again yourself with a new fresh top panel, after moving your current panel down to the bottom of the screen.

If you can't reproduce it anymore with the new panel, that means there's something particular to your old panel that's triggering the issue, and that should hopefully make it easier to narrow down the exact combination of settings that's doing it.
Comment 28 Natalie Clarius 2023-09-21 21:50:50 UTC
Ah, I think it's enabling the "fill free space on panel" option where it goes wrong.
Comment 29 Nate Graham 2023-09-21 22:01:01 UTC
Oh, that! Yes, that's a known issue.

*** This bug has been marked as a duplicate of bug 467385 ***