Bug 473360

Summary:	Built-in profile name is not localised
Product:	[Applications] konsole	Reporter:	Emir SARI <emir_sari>
Component:	general	Assignee:	Konsole Developer <konsole-devel>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nicolas.fella
Priority:	NOR
Version:	master
Target Milestone:	---
Platform:	Other
OS:	Other
Latest Commit:	https://invent.kde.org/utilities/konsole/-/commit/7b54cc9cd96b32d9170904f3fa065bd785397b04	Version Fixed In:
Sentry Crash Report:

Description Emir SARI 2023-08-14 10:54:27 UTC

The profile name "Built-in" is not localised, and it looks rather awkward as an English string among the other localised messages. This one should be marked as translatable as well.

Comment 1 Nicolas Fella 2023-08-14 12:04:14 UTC

As far as I can tell it tries to localize the name, but I guess it fails because of the intermediate variable

Comment 2 Bug Janitor Service 2023-08-14 12:20:17 UTC

A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/886

Comment 3 Kurt Hindenburg 2023-08-31 00:26:40 UTC

Git commit 7b54cc9cd96b32d9170904f3fa065bd785397b04 by Kurt Hindenburg, on behalf of Nicolas Fella.
Committed on 31/08/2023 at 01:58.
Pushed by hindenburg into branch 'master'.

Fix translating the builtin profile name

Having the name in a separate variable breaks extracting the translations

M  +2    -7    src/profile/Profile.cpp

https://invent.kde.org/utilities/konsole/-/commit/7b54cc9cd96b32d9170904f3fa065bd785397b04