Bug 473349

Summary:	Highlighted BasicListItem implementations sometimes have invisible text and icons
Product:	[Frameworks and Libraries] frameworks-qqc2-desktop-style	Reporter:	Nicolas Fella <nicolas.fella>
Component:	general	Assignee:	kdelibs bugs <kdelibs-bugs-null>
Status:	RESOLVED FIXED
Severity:	major	CC:	ahiemstra, aleixpol, bugseforuns, kde, nate, noahadvs, notmart
Priority:	NOR	Keywords:	qt6, regression
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	9edcfd832416532e6c49b4617ebacae11024af49	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Screenshot

Description Nicolas Fella 2023-08-13 21:54:33 UTC

Sidebar actions have the wrong text color when selected. See screenshot


SOFTWARE/OS VERSIONS
KDE Plasma Version: master
KDE Frameworks Version: master
Qt Version: 6.5.2

ADDITIONAL INFORMATION
discover b79db806fc392d703074588b1a95eeb6e39e6e9f

Comment 1 Nicolas Fella 2023-08-13 21:54:45 UTC

Created attachment 160938 [details]
Screenshot

Comment 2 Patrick Silva 2023-08-13 22:43:29 UTC

Can reproduce on neon unstable. System Monitor is also affected.

Comment 3 Nate Graham 2023-08-14 20:07:57 UTC

Can reproduce in both. Looks like the background color is missing for the highlighted state. Likely a regression following the styling changes to make BasicListItem inherit from ItemDelegate made a few weeks ago. Will investigate.

Comment 4 Nate Graham 2023-08-14 20:24:37 UTC

The proximate cause appears to be because https://invent.kde.org/frameworks/kirigami/-/commit/adf36c255f45ca55f98eafe5cd10642c417b4b45 migrated to using  ItemDelegate styling without migrating any of the more sophisticated list item background code to our ItemDelegate styling. As a result we lost separator lines, alternating background colors, and, apparently, the background color for the highlighted list item. :/

Commented in https://invent.kde.org/frameworks/kirigami/-/merge_requests/1175.

Comment 5 Marco Martin 2023-08-15 07:41:07 UTC

do those items have the highlighted property set to true?
if so, that's a qqc2-desktop-style bug.

Comment 6 Marco Martin 2023-08-15 08:20:23 UTC

ok, so, the change to do is checked->highlighted

doing that in kirigami global drawer fixes most of them already. it remains one thing to do in discover.

other things like systemsettings already do the right thing

Comment 7 Nate Graham 2023-08-15 16:38:23 UTC

Indeed, this seems to be an issue in /home/nate/kde/src/kirigami/src/controls/private/GlobalDrawerActionItem.qml, which has a custom AbstractListItem subclass rather than just using BasicListItem. I'll see if I can fix it, or port to BasicListItem if possible.

Comment 8 Nate Graham 2023-08-15 17:25:48 UTC

Fixed already by Marco Martin with 9edcfd832416532e6c49b4617ebacae11024af49.