Summary: | Kickoff is taking focus away after being closed with meta key. | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | notmyfirstrealname <c354r.r0m> |
Component: | Application Launcher (Kickoff) | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dev, lordofthecoffee, mikel5764, nate, noahadvs, qydwhotmail, serfreeman1337 |
Priority: | VHI | Keywords: | regression |
Version: | 5.27.7 | ||
Target Milestone: | 1.0 | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/-/commit/81e118150c12d2c6481e71feebfc9a34710c057a | Version Fixed In: | 5.27.7.1 |
Attachments: | Loosing focus on closing by meta key |
Description
notmyfirstrealname
2023-08-02 04:56:48 UTC
Created attachment 160677 [details]
Loosing focus on closing by meta key
Can confirm. Reverting this commit solved the issue: https://invent.kde.org/plasma/plasma-desktop/-/commit/648e10cea66926e93b52b9a7e0cc65b4055448e6 Cannot reproduce on Plasma 6. *** Bug 472935 has been marked as a duplicate of this bug. *** Raising priority due to the visibility of the issue and how often it will affect people, despite its relatively minor effect. *** Bug 472947 has been marked as a duplicate of this bug. *** Git commit d9f39abdb402a81465dca79c791a229778e97efb by Fushan Wen. Committed on 04/08/2023 at 16:06. Pushed by fusionfuture into branch 'Plasma/5.27'. Panel: fix applet not returning focus after pressing applet shortcut When applet shortcut is pressed for the first time, panel also gets activated, but the status will change to RequiresAttentionStatus after applet also gets activated later. When applet is activated, panel status is not AcceptingInputStatus but RequiresAttentionStatus, so unconditionally changing to AcceptingInputStatus when the current status is not AcceptingInputStatus is wrong. FIXED-IN: 5.27.8 M +4 -2 desktoppackage/contents/views/Panel.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/d9f39abdb402a81465dca79c791a229778e97efb Git commit 81e118150c12d2c6481e71feebfc9a34710c057a by Fushan Wen. Committed on 04/08/2023 at 16:08. Pushed by fusionfuture into branch 'master'. Panel: fix applet not returning focus after pressing applet shortcut When applet shortcut is pressed for the first time, panel also gets activated, but the status will change to RequiresAttentionStatus after applet also gets activated later. When applet is activated, panel status is not AcceptingInputStatus but RequiresAttentionStatus, so unconditionally changing to AcceptingInputStatus when the current status is not AcceptingInputStatus is wrong. FIXED-IN: 5.27.8 (cherry picked from commit d9f39abdb402a81465dca79c791a229778e97efb) M +4 -2 desktoppackage/contents/views/Panel.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/81e118150c12d2c6481e71feebfc9a34710c057a A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1961 Git commit 599df6fd3a9e6fb562574391f4b47330a178b780 by Fushan Wen. Committed on 05/01/2024 at 17:45. Pushed by fusionfuture into branch 'master'. Panel: fix connection target for onActivated on X11 It needs Containment instead of ContainmentItem. On Wayland the focus restoration is done in other places. M +4 -4 desktoppackage/contents/views/Panel.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/599df6fd3a9e6fb562574391f4b47330a178b780 Git commit 5b7fa25b3d78a232829f7063a85408eb5a682d80 by Fushan Wen. Committed on 07/01/2024 at 05:01. Pushed by fusionfuture into branch 'master'. appiumtests: add test for bug 472909 M +5 -1 appiumtests/CMakeLists.txt A +98 -0 appiumtests/bug472909.py A +42 -0 appiumtests/resources/bug472909_activewindow.py https://invent.kde.org/plasma/plasma-desktop/-/commit/5b7fa25b3d78a232829f7063a85408eb5a682d80 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3868 Git commit 6bde0db646591652628416a99e6ca29d5b573617 by Marco Martin. Committed on 06/02/2024 at 08:13. Pushed by mart into branch 'master'. Fix Panel renouncing focus On x11, removing the acceptfocus doesn't actually remove the focus from the window Use also here m_corona->restorePreviousWindow() to focus the old window This is a more effective bugfix thanthe ugly workaround present in the Panel.qml shell package See https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2026 M +4 -2 shell/panelview.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/6bde0db646591652628416a99e6ca29d5b573617 Git commit 541056c8cd251a3efc2d13ab0638216253bd6ca4 by Marco Martin. Committed on 06/02/2024 at 08:14. Pushed by mart into branch 'Plasma/6.0'. Fix Panel renouncing focus On x11, removing the acceptfocus doesn't actually remove the focus from the window Use also here m_corona->restorePreviousWindow() to focus the old window This is a more effective bugfix thanthe ugly workaround present in the Panel.qml shell package See https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2026 M +4 -2 shell/panelview.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/541056c8cd251a3efc2d13ab0638216253bd6ca4 |