Bug 472779

Summary: 5.2 beta1 - Soften edge slider on Sharpness feature doesn't work
Product: [Applications] krita Reporter: apelsinchoklad
Component: Brush enginesAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: tomtomtomreportingin
Priority: NOR Keywords: regression
Version: unspecified   
Target Milestone: ---   
Platform: macOS (DMG)   
OS: macOS   
Latest Commit: https://invent.kde.org/graphics/krita/-/commit/5209cf9464fd7bb5c9fe1e9c02365e659b755409 Version Fixed In:
Sentry Crash Report:

Description apelsinchoklad 2023-07-29 18:29:32 UTC 
SUMMARY
***
Soften edge slider on Sharpness feature in the pixel brush engine doesn't work in 5.2 beta1, produces sharp edge look regardless of value. Tested on macOS and openSUSE tumbleweed. Can be seen on 'c) SK-13 Basic TILT' from the SK V1 Bundle as an example.

STEPS TO REPRODUCE
1. Pick 'b) Airbrush Soft'
2. Activate Sharpness feature and set strength to 70%
3. Paint a stroke with Soften Edge at 0, paint another one with Soften edge at 100

OBSERVED RESULT
Both strokes look the same.

EXPECTED RESULT
In 5.1.5 the stroke painted with Soften edge at 100 have a partially soft edge.

SOFTWARE/OS VERSIONS
macOS: 10.13.6
Linux/KDE Plasma: openSUSE tumbleweed with Plasma DE
Comment 1 tomtomtomreportingin 2023-07-29 23:04:00 UTC 
I can confirm. Some of the Sharpness options including https://bugs.kde.org/show_bug.cgi?id=472723 might have broke as part of the recent brush editor refactoring.
Comment 2 Dmitry Kazakov 2023-08-14 16:11:54 UTC 
Git commit 5fdf853a1a1fe21b04c6bf02584762040bd66628 by Dmitry Kazakov.
Committed on 14/08/2023 at 18:11.
Pushed by dkazakov into branch 'master'.

Fix sharpness option being uninitialized
Related: bug 472723

M  +1    -1    plugins/paintops/libpaintop/KisSharpnessOption.cpp

https://invent.kde.org/graphics/krita/-/commit/5fdf853a1a1fe21b04c6bf02584762040bd66628
Comment 3 Dmitry Kazakov 2023-08-14 16:12:44 UTC 
Git commit 5209cf9464fd7bb5c9fe1e9c02365e659b755409 by Dmitry Kazakov.
Committed on 14/08/2023 at 18:12.
Pushed by dkazakov into branch 'krita/5.2'.

Fix sharpness option being uninitialized
Related: bug 472723

M  +1    -1    plugins/paintops/libpaintop/KisSharpnessOption.cpp

https://invent.kde.org/graphics/krita/-/commit/5209cf9464fd7bb5c9fe1e9c02365e659b755409