| Summary: | File System Browser plugin search doesn't work | ||
|---|---|---|---|
| Product: | [Applications] kate | Reporter: | Pascal <CoolP> |
| Component: | application | Assignee: | KWrite Developers <kwrite-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kdelibs-bugs-null, kossebau, waqar.17a |
| Priority: | NOR | ||
| Version First Reported In: | 23.04.3 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/utilities/kate/-/commit/8815056d7c9d203525a0a422bbbeb76495e844ce | Version Fixed In: | 23.08.0 |
| Sentry Crash Report: | |||
|
Description
Pascal
2023-07-18 22:29:34 UTC
Adding: Searching terms within documents works fine. It's just the File System Browser's search that's affected. Even after being on the backports ppa in terms of timely updates (and possible fixes), the problem persists on current and freshly installed machines and is not present on older Kate builds. Strangely enough, I couldn't find any other reports about it. Additional input and/or confirmation welcome. Moving to KIO since that's where it's broken, we can't do anything about it in Kate. You can search for `text*` and it will give you all matches. Thanks for the tip and info. Much appreciated. I never tried that workaround but it's fine, once you know it. Regarding KIO, I'm assuming this means "KDE input/output" and that's where the fix has to happen? As commented on https://invent.kde.org/frameworks/kio/-/merge_requests/1314#note_728978 I would think that Kate actually relied on a behaviour change that was reverted in the mean time as it broke things for filter expressions as used also in file picker dialogs. The current (restored) logic in KIO's KCoreDirLister for name filters matches that of Qt for name filter properties. I.e. name filters here using the wildcard expression syntax. Which is non-partial. The UI pattern used in Kate's File System Browser plugin though is that of narrowing-while-you-type. Where the expression supported usually does not support even wildcards. Rather acts as if every letter is wrapped with wildcards ("sf" matching also "somefile"). So IMHO Kate code would need to convert the expression entered in the field into the syntax used for classic wild card file system expressions, as so far used with class properties of type "name filter". If you agree, please move the bug back to Kate :) Interesting background and suggestion, Friedrich. Thanks for that. I see that you are on this issue for some time already. Since I'm new to this system, I'm not sure if your wish regarding the move addressed me or Waqar Ahmed, although I would assume the latter. Moving back to Kate, MR upcoming... A possibly relevant merge request was started @ https://invent.kde.org/utilities/kate/-/merge_requests/1274 Git commit 487b28b4de1bbf34cf730e9ff1a9a9f0d5b96efb by Christoph Cullmann, on behalf of Friedrich W. H. Kossebau. Committed on 03/08/2023 at 15:37. Pushed by cullmann into branch 'release/23.08'. File Browser plugin: make search string partial-matching FIXED-IN: 23.08.0 M +10 -1 addons/filebrowser/katefilebrowser.cpp https://invent.kde.org/utilities/kate/-/commit/487b28b4de1bbf34cf730e9ff1a9a9f0d5b96efb Git commit 8815056d7c9d203525a0a422bbbeb76495e844ce by Christoph Cullmann, on behalf of Friedrich W. H. Kossebau. Committed on 03/08/2023 at 16:04. Pushed by cullmann into branch 'master'. File Browser plugin: make search string partial-matching FIXED-IN: 23.08.0 (cherry picked from commit 487b28b4de1bbf34cf730e9ff1a9a9f0d5b96efb) M +10 -1 addons/filebrowser/katefilebrowser.cpp https://invent.kde.org/utilities/kate/-/commit/8815056d7c9d203525a0a422bbbeb76495e844ce |