| Summary: | Subliminal white screen interleaved at picture transition | ||
|---|---|---|---|
| Product: | [Applications] gwenview | Reporter: | Matthieu Carteron <rubisetcie> |
| Component: | general | Assignee: | Gwenview Bugs <gwenview-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | erikviva, nate |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/gwenview/-/commit/2bf8ebf74ccb3e29f530ce41b634fff43840380d | Version Fixed/Implemented In: | 23.08 |
| Sentry Crash Report: | |||
|
Description
Matthieu Carteron
2023-07-18 11:48:09 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/gwenview/-/merge_requests/213 Git commit 35a5a93867f9f4a5d4bed896df1cb4180cfdac87 by Felix Ernst, on behalf of Felix Ernst. Committed on 02/08/2023 at 10:56. Pushed by felixernst into branch 'master'. Make image switching seamless when animations are disabled Previously, switching images meant that between hiding of the first image and showing of the next image there would be a blank screen when animations are disabled. This brief flickering isn't aesthetic and makes direct comparisons of similar images more difficult. This commit makes the switching of images seamless when animations are disabled. It does so by disabling the updating/repainting of the view container until the loading of the new image has completed(). If loading takes long enough that we would want to show a loading indicator the seamless experience is given up on and we do show a loading indicator instead. M +1 -0 lib/documentview/documentview.cpp M +6 -0 lib/documentview/documentview.h M +11 -0 lib/documentview/documentviewcontainer.cpp https://invent.kde.org/graphics/gwenview/-/commit/35a5a93867f9f4a5d4bed896df1cb4180cfdac87 Git commit 2bf8ebf74ccb3e29f530ce41b634fff43840380d by Felix Ernst, on behalf of Felix Ernst. Committed on 02/08/2023 at 11:28. Pushed by felixernst into branch 'release/23.08'. Make image switching seamless when animations are disabled Previously, switching images meant that between hiding of the first image and showing of the next image there would be a blank screen when animations are disabled. This brief flickering isn't aesthetic and makes direct comparisons of similar images more difficult. This commit makes the switching of images seamless when animations are disabled. It does so by disabling the updating/repainting of the view container until the loading of the new image has completed(). If loading takes long enough that we would want to show a loading indicator the seamless experience is given up on and we do show a loading indicator instead. (cherry picked from commit 35a5a93867f9f4a5d4bed896df1cb4180cfdac87) M +1 -0 lib/documentview/documentview.cpp M +6 -0 lib/documentview/documentview.h M +11 -0 lib/documentview/documentviewcontainer.cpp https://invent.kde.org/graphics/gwenview/-/commit/2bf8ebf74ccb3e29f530ce41b634fff43840380d |