Bug 472284

Summary: Modifying the playlist while Elisa is playing results in a wrong playing order
Product: [Applications] Elisa Reporter: Elias <mosaulp>
Component: generalAssignee: Jack Hill <jackhill3103>
Status: RESOLVED FIXED    
Severity: normal CC: jackhill3103, nate
Priority: HI    
Version First Reported In: 23.04.2   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: https://invent.kde.org/multimedia/elisa/-/commit/0e6fdd58908fd86d924ce040902be4635e90545a Version Fixed/Implemented In:
Sentry Crash Report:

Description Elias 2023-07-15 15:22:41 UTC 
SUMMARY
When a song from above the currently playing position is moved to the position after the currently playing, Elisa does not play this song next. Instead the next song playing is one from above the current position or the current position again.

STEPS TO REPRODUCE
1. Create a playlist with three songs.
2. Play the last (third) song by double clicking it.
3. Drag the first song to the last position.
4. The next song that will be played is not the expected (just dragged) one.

OBSERVED RESULT
The next song playing will be song two of the playlist (the one, you just listened to). In longer playlists it could be another one from above the current position, but it will never be the recently dragged song.

EXPECTED RESULT
The now third (former fist) song should be played. After the dragging the song this is the next song in the list, thus it should be played next.

SOFTWARE/OS VERSIONS
Operating System: Fedora Linux 38
KDE Plasma Version: 5.27.6
KDE Frameworks Version: 5.107.0
Qt Version: 5.15.10
Kernel Version: 6.3.12-200.fc38.x86_64 (64-bit)
Graphics Platform: Wayland
Comment 1 Nate Graham 2023-09-12 18:19:21 UTC 
Erk, can reproduce.
Comment 2 Jack Hill 2023-09-15 17:01:55 UTC 
An undoubtedly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/488
Comment 3 Nate Graham 2023-09-18 16:52:03 UTC 
Git commit 0e6fdd58908fd86d924ce040902be4635e90545a by Nate Graham, on behalf of Jack Hill.
Committed on 18/09/2023 at 18:46.
Pushed by ngraham into branch 'master'.

mediaplaylistproxymodel: update playlist indices when moving the current track

Update previous/next track
Update mCurrentPlayListPosition
Emit currentTrackRowChanged
Related: bug 471429, bug 471456

M  +14   -2    src/mediaplaylistproxymodel.cpp
M  +2    -0    src/mediaplaylistproxymodel.h

https://invent.kde.org/multimedia/elisa/-/commit/0e6fdd58908fd86d924ce040902be4635e90545a