Bug 472232

Summary:	Author list commit numbers are wrong (sometimes even zero)
Product:	[Applications] kommit	Reporter:	Karl Ove Hufthammer <karl>
Component:	general	Assignee:	Hamed Masafi <Hamed.Masafi>
Status:	RESOLVED FIXED
Severity:	normal	CC:	montel
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Karl Ove Hufthammer 2023-07-13 19:51:47 UTC

SUMMARY
The number of of commits in the Authors panel are wrong. Some authors are even listed with zero commits, which shouldn’t be possible.


STEPS TO REPRODUCE
1. Check out https://invent.kde.org/libraries/kirigami-addons.git
2. Go to the Authors panel
3. Click the Commits header
4. Scroll up/down so you see the authors with fewest commits


OBSERVED RESULT
Some authors are listed with 0 commits.

And the number of commits in general don’t always match the output of ‘git shortlog -sne’ (even for authors with unique email addresses). Some numbers match, but some numbers are lower (e.g., 0) or higher (even if we include ‘--all’ to the git shortlog command). 


EXPECTED RESULT
The numbers should match the git shortlog numbers.


SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.27
KDE Plasma Version: 5.27.6
KDE Frameworks Version: 5.108.0
Qt Version: 5.15.10

Comment 1 Hamed Masafi 2023-07-14 08:11:20 UTC

Hi

Thanks for bug reporting
Actualy there are 3 reasons to add a person as author in that list.
1. make a commit
2. auth a commit
3. make a tag

In other words, those who you see in the list do not have a commit, they probably authed another commit or created a tag.
I will add two more columns so that this list displays the complete information.

Thanks again

Comment 2 Karl Ove Hufthammer 2023-07-14 10:52:49 UTC

Thanks. I have tested the updated Git version, and there seems to be some deduplication issues. There’s an extra row for people who have added tags (i.e., their names are shown twice). The only difference is that their email addresses for the Tags row are shown with angle brackets.

One example from the repository I mentioned is Nicolas Fella. He has one row (nicolas.fella@gmx.de) with 20 commits, 22 autheds and 0 tags. And one row (<nicolas.fella@gmx.de>, note the angle brackets) with 0 commits, 0 autheds and 1 tag.

Comment 3 Karl Ove Hufthammer 2023-07-14 11:00:36 UTC

BTW, the tag information isn’t really reliable. It’s shown even for lightweight tags, i.e., tags that don’t have any author information stored. I guess the name is taken from the committer or author (which is typically *not* the person creating the tag)?

Comment 4 Karl Ove Hufthammer 2023-07-15 13:29:09 UTC

I found one more problem with the author statistics. For the Kommit repo itself, one person is listed with no name or email address, but 1 in the Autheds column. If I compare the statistics with git log/shortlog, the person is Xin Liu <ginshio78@gmail.com>. Both the name and the email address looks normal, so it’s a bit strange that they’re shown as empty strings.

Comment 5 Hamed Masafi 2024-04-24 15:10:51 UTC

This part is rewriten and authors list formed into the reports