Bug 472095

Summary:	Outdated currency for Croatia
Product:	[Applications] KDE Itinerary	Reporter:	Petr Kadlec <mormegil>
Component:	general	Assignee:	Volker Krause <vkrause>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Android
OS:	Android 13.x
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Petr Kadlec 2023-07-09 09:26:38 UTC

SUMMARY
Croatia adopted the euro in 2023, however, KItinerary still displays HRK as its currency.

It seems KItinerary takes the country currency data from KCountry, which takes them... from QLocale? So, I have no idea what the expected update flow is. Is this just a matter of updating some of those libraries to the current version? Or an upstream bug for KCountry? Or even Qt? No idea and I'm currently incapable of checking this myself. (On vacation in Croatia ;-)) 

STEPS TO REPRODUCE
1. Import a trip to Croatia.

OBSERVED RESULT
A "You are entering Croatia" information entry is displayed, with "Currency: HRK" 

EXPECTED RESULT
"Currency: EUR" should be displayed instead. 

SOFTWARE/OS VERSIONS
Android app version 23.04.3 installed from F-Droid KDE repo. 
Android 13

Comment 1 Volker Krause 2023-07-09 09:49:12 UTC

Good point. My first guess is that's coming from Qt: https://invent.kde.org/qt/qt/qtbase/-/blob/dev/src/corelib/text/qlocale_data_p.h#L1268. And those data tables are generated from CLDR AFAIK. Might be worth checking if there is an update we can backport, which would seem cleaner than patching those tables...

Comment 2 Petr Kadlec 2023-07-09 20:19:54 UTC

Yeah, the CLDR update seems to be released in CLDR v42 <https://cldr.unicode.org/index/downloads/cldr-42>.

QT have been updated to CLDR v42 in <https://github.com/qt/qtbase/commit/9a8b9473d5f0fd4639193481ba9b344d91f3f00a> which was... part of 6.5.0, if I read it correctly. <https://github.com/qt/qtbase/commit/b66a83b74e8f44594b2404c31565a6ede95c77ac>

Comment 3 Volker Krause 2023-07-11 17:16:42 UTC

Right, Qt 6 already has the correct currency, https://invent.kde.org/qt/qt/qtbase/-/merge_requests/264 fixes that for Qt 5.15.

Comment 4 Volker Krause 2023-08-22 17:32:07 UTC

The backport was merged a month ago and has meanwhile propagated to all packages.