Bug 471813

Summary: In brush mode, quickly pressing CTRL+Z after pressing V to draw a straight line crashes the program if the straight line is not done drawing.
Product: [Applications] krita Reporter: tin1771718335
Component: * UnknownAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED UPSTREAM    
Severity: crash CC: dimula73
Priority: NOR    
Version First Reported In: 5.1.5   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description tin1771718335 2023-07-01 03:50:11 UTC
STEPS TO REPRODUCE
1. Open a blank canvas of any size and enter brush mode (any brush should do, I tried with Basic-5 Size)
2. Hold V and draw a straight line
3. After releasing the cursor and before the straight line is (fully) drawn, press CTRL+Z

OBSERVED RESULT
Crashed :)

EXPECTED RESULT
The drawn straight line is undone

SOFTWARE/OS VERSIONS
Linux Kernel Version: 6.3.9-arch1-1 (64-bit) 
KDE Plasma Version:  5.27.6
KDE Frameworks Version: 5.107.0
Qt Version: 5.15.10

ADDITIONAL INFORMATION

Bug report:
================================================================================
01 Jul 2023 10:27:51 +0800. Executing krita

Krita Version: 5.1.5, Qt version compiled: 5.15.7, loaded: 5.15.7. Process ID: 2
-- -- -- -- -- -- -- --
01 Jul 2023 10:27:51 +0800: Style: fusion. Available styles: Windows, Fusion
01 Jul 2023 10:27:52 +0800: Database is up to date. Version: 0.0.17, created by Krita 5.1.5, at Fri June 16 12:47:19 2023
01 Jul 2023 10:27:58 +0800: Importing application/x-krita to application/x-krita. Location: /home/tin/Pictures/Art/clip files/Rain World.kra. Real location: /home/tin/Pictures/Art/clip files/Rain World.kra. Batchmode: 0
01 Jul 2023 10:27:58 +0800: Loaded image from application/x-krita. Size: 3840 * 2160 pixels, 8.33333 dpi. Color model: 8-bit integer/channel RGB/Alpha (sRGB-elle-V2-srgbtrc.icc). Layers: 15
01 Jul 2023 10:28:27 +0800: ASSERT (krita): "!qimage.isNull()" in file /run/build/krita/libs/ui/kis_clipboard.cc, line 460

KRITA DID NOT CLOSE CORRECTLY
================================================================================


coredumpctl info:
================================================================================
           PID: 5906 (krita)
           UID: 1000 (tin)
           GID: 1000 (tin)
        Signal: 6 (ABRT)
     Timestamp: Sat 2023-07-01 10:28:27 AWST (1h 20min ago)
  Command Line: krita
    Executable: /app/bin/krita
 Control Group: /user.slice/user-1000.slice/user@1000.service/app.slice/app-flatpak-org.kde.krita-5894.scope
          Unit: user@1000.service
     User Unit: app-flatpak-org.kde.krita-5894.scope
         Slice: user-1000.slice
     Owner UID: 1000 (tin)
       Boot ID: 9806a1fff4044f8684e988d484e69f24
    Machine ID: 7394f17c4e62499a877399df094ea5c2
      Hostname: Arch
       Storage: /var/lib/systemd/coredump/core.krita.1000.9806a1fff4044f8684e988d484e69f24.5906.1688178507000000.zst (present)
  Size on Disk: 130.3M
       Message: Process 5906 (krita) of user 1000 dumped core.
                
                Stack trace of thread 2:
                #0  0x00007f5c03891184 n/a (/usr/lib/x86_64-linux-gnu/libc.so.6 + 0x91184)
                #1  0x00007f5c0383f00e n/a (/usr/lib/x86_64-linux-gnu/libc.so.6 + 0x3f00e)
                #2  0x00007f5c038287fc n/a (/usr/lib/x86_64-linux-gnu/libc.so.6 + 0x287fc)
                #3  0x00007f5c0409dcaf n/a (/app/lib/libQt5Core.so.5.15.7 + 0x9dcaf)
                #4  0x00007f5c06020158 n/a (/app/lib/libkritaui.so.18.0.0 + 0x420158)
                #5  0x00007f5c06020681 n/a (/app/lib/libkritaui.so.18.0.0 + 0x420681)
                #6  0x00007f5c06020c40 n/a (/app/lib/libkritaui.so.18.0.0 + 0x420c40)
                #7  0x00007f5c062b4230 n/a (/app/lib/libkritaui.so.18.0.0 + 0x6b4230)
                #8  0x00007f5c060cf1c2 n/a (/app/lib/libkritaui.so.18.0.0 + 0x4cf1c2)
                #9  0x00007f5c0430568c n/a (/app/lib/libQt5Core.so.5.15.7 + 0x30568c)
                #10 0x00007f5c04f75802 n/a (/app/lib/libQt5Widgets.so.5.15.7 + 0x175802)
                ELF object binary architecture: AMD x86-64
================================================================================
Comment 1 Dmitry Kazakov 2023-07-06 08:27:15 UTC
Hi, tin177178335!

Could you please check if the bug is present in the Nightly AppImage builds of Krita? I guess the problem has been resolved in this commit:

https://invent.kde.org/graphics/krita/-/commit/f4f069cbea3dd961aed23e3abbc67460821b2da9

Nightly AppImage package: https://binary-factory.kde.org/job/Krita_Nightly_Appimage_Build/
Comment 2 tin1771718335 2023-07-07 05:20:51 UTC
(In reply to Dmitry Kazakov from comment #1)

Hey Dmitry,

Yes, the newest AppImage appears to have fixed this issue! Thanks for letting me know :D