Bug 471561

Summary:	Detected function "onIsMenuChanged" in Connections element. This is probably intended to be a signal handler but no signal of the target matches the name.
Product:	[Frameworks and Libraries] frameworks-kirigami	Reporter:	Justin Zobel <justin.zobel>
Component:	general	Assignee:	kdelibs bugs <kdelibs-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	nate, notmart
Priority:	NOR	Keywords:	qt6
Version First Reported In:	unspecified
Target Milestone:	Not decided
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/frameworks/kirigami/-/commit/81f01c06ca0509df1c542a6e96499299279e52c7	Version Fixed/Implemented In:	6.0
Sentry Crash Report:

Description Justin Zobel 2023-06-29 10:14:55 UTC

While doing Qt6 porting of https://invent.kde.org/utilities/kclock/-/commits/work/jz/qt6-work I came across the following error:

file:///usr/lib64/qt6/qml/org/kde/kirigami/private/globaltoolbar/PageRowGlobalToolBarUI.qml:74:13: QML Connections: Detected function "onIsMenuChanged" in Connections element. This is probably intended to be a signal handler but no signal of the target matches the name.

It refers to https://invent.kde.org/frameworks/kirigami/-/blob/master/src/controls/private/globaltoolbar/PageRowGlobalToolBarUI.qml

I spoke with sporknife who authored the commit, and they asked me to file a bug in relation to Kirigami as it's possibly Qt6 being more strict than Qt5 with function paramaters.

Comment 1 Nate Graham 2023-07-17 04:22:31 UTC

Can reproduce.

Comment 2 Bug Janitor Service 2023-07-17 04:24:19 UTC

A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/1181

Comment 3 Nate Graham 2023-08-01 14:58:22 UTC

Git commit 81f01c06ca0509df1c542a6e96499299279e52c7 by Nate Graham.
Committed on 01/08/2023 at 16:53.
Pushed by ngraham into branch 'master'.

Suppress onIsMenuChanged runtime error messages

PageRowGlobalToolBarUI makes a connection to onIsMenuChanged in
applicationWindow().globalDrawer, but somteimes it's not actually a
GLobalDrawer and doesn't have the right signal. So we want to make sure
we're only targeting it if it is in fact a GlobalDrawer. Otherwise it
won't have the needed signal and we'll get a warning.
FIXED-IN: 6.0

M  +1    -1    src/controls/private/globaltoolbar/PageRowGlobalToolBarUI.qml

https://invent.kde.org/frameworks/kirigami/-/commit/81f01c06ca0509df1c542a6e96499299279e52c7