| Summary: | Unsplash does not return an image (404 error) | ||
|---|---|---|---|
| Product: | [Unmaintained] kdeplasma-addons | Reporter: | Nicola Smaniotto <smaniotto.nicola> |
| Component: | Picture of the Day | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | i, julius.berger, nate, qydwhotmail |
| Priority: | NOR | ||
| Version First Reported In: | 5.27.6 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kdeplasma-addons/-/commit/4829e7366272babebb3933543da065e191d41c1c | Version Fixed/Implemented In: | 5.27.7 |
| Sentry Crash Report: | |||
|
Description
Nicola Smaniotto
2023-06-28 09:22:30 UTC
Git commit 2dc3455ad624f2e963b2d61405f38e770116dba4 by Fushan Wen. Committed on 28/06/2023 at 16:46. Pushed by fusionfuture into branch 'master'. wallpapers/potd: remove unsplash provider https://source.unsplash.com has been deprecated and doesn't work anymore. To use Unslash in needs a developer access key and use the https://api.unsplash.com FIXED-IN: 5.27.7 M +0 -4 wallpapers/potd/package/contents/config/main.xml M +1 -149 wallpapers/potd/package/contents/ui/config.qml M +1 -4 wallpapers/potd/package/contents/ui/main.qml M +0 -3 wallpapers/potd/plugins/providers/CMakeLists.txt D +0 -46 wallpapers/potd/plugins/providers/unsplashprovider.cpp D +0 -26 wallpapers/potd/plugins/providers/unsplashprovider.h D +0 -48 wallpapers/potd/plugins/providers/unsplashprovider.json https://invent.kde.org/plasma/kdeplasma-addons/-/commit/2dc3455ad624f2e963b2d61405f38e770116dba4 (In reply to Fushan Wen from comment #1) > Git commit 2dc3455ad624f2e963b2d61405f38e770116dba4 by Fushan Wen. > Committed on 28/06/2023 at 16:46. > Pushed by fusionfuture into branch 'master'. > > wallpapers/potd: remove unsplash provider > > https://source.unsplash.com has been deprecated and doesn't work > anymore. To use Unslash in needs a developer access key and use > the https://api.unsplash.com > FIXED-IN: 5.27.7 > > M +0 -4 wallpapers/potd/package/contents/config/main.xml > M +1 -149 wallpapers/potd/package/contents/ui/config.qml > M +1 -4 wallpapers/potd/package/contents/ui/main.qml > M +0 -3 wallpapers/potd/plugins/providers/CMakeLists.txt > D +0 -46 wallpapers/potd/plugins/providers/unsplashprovider.cpp > D +0 -26 wallpapers/potd/plugins/providers/unsplashprovider.h > D +0 -48 wallpapers/potd/plugins/providers/unsplashprovider.json > > https://invent.kde.org/plasma/kdeplasma-addons/-/commit/ > 2dc3455ad624f2e963b2d61405f38e770116dba4 After reading the terms of the new developer access possibilities for unsplash, I would think the KDE wallpaper engine might be a valid use case if used on a personal basis. So why not enabling this integration with the possibility to enter an API key and further use the feature, instead of completely removing it? We could also talk to the Unsplash support to get some view of them on the situation... Git commit 365b58ed5ca0e30e207ff8127ad51b9d5482a76b by Fushan Wen. Committed on 29/06/2023 at 10:53. Pushed by fusionfuture into branch 'Plasma/5.27'. wallpapers/potd: remove unsplash provider https://source.unsplash.com has been deprecated and doesn't work anymore. To use Unsplash one needs a developer access key and use https://api.unsplash.com The API Guidelines say: > You cannot replicate the core user experience of Unsplash (unofficial clients, wallpaper applications, etc.). > a wallpaper app returns Unsplash images for downloading. Without the integration, the app has no content and no value to users. > The API is to be used for non-automated, high-quality, and authentic experiences. So the Unsplash provider has to be removed. FIXED-IN: 5.27.7 Ref: https://github.com/jerrykuku/luci-theme-argon/pull/422 M +0 -4 wallpapers/potd/package/contents/config/main.xml M +1 -144 wallpapers/potd/package/contents/ui/config.qml M +1 -4 wallpapers/potd/package/contents/ui/main.qml M +0 -3 wallpapers/potd/plugins/providers/CMakeLists.txt D +0 -47 wallpapers/potd/plugins/providers/unsplashprovider.cpp D +0 -26 wallpapers/potd/plugins/providers/unsplashprovider.h D +0 -47 wallpapers/potd/plugins/providers/unsplashprovider.json https://invent.kde.org/plasma/kdeplasma-addons/-/commit/365b58ed5ca0e30e207ff8127ad51b9d5482a76b Git commit 4829e7366272babebb3933543da065e191d41c1c by Fushan Wen. Committed on 29/06/2023 at 11:00. Pushed by fusionfuture into branch 'master'. wallpapers/potd: remove unsplash provider https://source.unsplash.com has been deprecated and doesn't work anymore. To use Unsplash one needs a developer access key and use https://api.unsplash.com The API Guidelines say: > You cannot replicate the core user experience of Unsplash (unofficial clients, wallpaper applications, etc.). > a wallpaper app returns Unsplash images for downloading. Without the integration, the app has no content and no value to users. > The API is to be used for non-automated, high-quality, and authentic experiences. So the Unsplash provider has to be removed. FIXED-IN: 5.27.7 Ref: https://github.com/jerrykuku/luci-theme-argon/pull/422 (cherry picked from commit 365b58ed5ca0e30e207ff8127ad51b9d5482a76b) M +0 -4 wallpapers/potd/package/contents/config/main.xml M +1 -149 wallpapers/potd/package/contents/ui/config.qml M +1 -4 wallpapers/potd/package/contents/ui/main.qml M +0 -3 wallpapers/potd/plugins/providers/CMakeLists.txt D +0 -46 wallpapers/potd/plugins/providers/unsplashprovider.cpp D +0 -26 wallpapers/potd/plugins/providers/unsplashprovider.h D +0 -48 wallpapers/potd/plugins/providers/unsplashprovider.json https://invent.kde.org/plasma/kdeplasma-addons/-/commit/4829e7366272babebb3933543da065e191d41c1c I have a new idea. Feel free to discuss on https://discuss.kde.org/t/a-generic-picture-of-the-day-provider/2579 |