Bug 471513

Summary: kdenetwork-filesharing UI does not appear with KF6
Product: [Frameworks and Libraries] kdenetwork-filesharing Reporter: Nate Graham <nate>
Component: generalAssignee: Unassigned bugs mailing-list <unassigned-bugs>
Status: RESOLVED FIXED    
Severity: grave CC: bugseforuns, justin.zobel, sitter
Priority: NOR Keywords: qt6
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Nate Graham 2023-06-27 18:32:58 UTC
The main UI doesn't appear, and the following error is seen:

qrc:/org.kde.filesharing.samba/qml/main.qml:12:1: QML StackView: push: qrc:/org.kde.filesharing.samba/qml/GroupPage.qml:55 Cannot assign to non-existent property "iconName"

Needs a KF6 branch, or else some CMake magic to support both.
Comment 1 Justin Zobel 2023-06-29 05:29:05 UTC
Can confirm this as well.
Comment 2 Patrick Silva 2023-08-08 13:13:34 UTC
On my neon unstable "Share" tab is available in the Properties of a folder.
Comment 3 Nate Graham 2023-08-08 19:30:04 UTC
The tab appears, but its content is broken and missing.
Comment 4 Harald Sitter 2023-11-22 11:11:22 UTC
Git commit fcd8e2fc3f80ba923a3f3c2f282c1f17c260e105 by Harald Sitter.
Committed on 21/11/2023 at 17:02.
Pushed by ltoscano into branch 'master'.

kf6 port

M  +0    -2    .gitlab-ci.yml
M  +0    -11   .kde-ci.yml
M  +10   -17   CMakeLists.txt
M  +5    -5    samba/aclproperties/CMakeLists.txt
M  +2    -2    samba/aclproperties/qml/MainPage.qml
M  +11   -20   samba/filepropertiesplugin/CMakeLists.txt
M  +1    -1    samba/filepropertiesplugin/qml/ChangePassword.qml
M  +1    -1    samba/filepropertiesplugin/qml/GroupPage.qml
M  +1    -1    samba/filepropertiesplugin/qml/InstallPage.qml
M  +1    -1    samba/filepropertiesplugin/qml/RebootPage.qml

https://invent.kde.org/network/kdenetwork-filesharing/-/commit/fcd8e2fc3f80ba923a3f3c2f282c1f17c260e105