Bug 471456

Summary:	Modifying playlist position of current song breaks pause
Product:	[Applications] Elisa	Reporter:	Quinten Kock <quinten>
Component:	general	Assignee:	Matthieu Gallien <matthieu_gallien>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate
Priority:	NOR
Version First Reported In:	23.04.2
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:	https://invent.kde.org/multimedia/elisa/-/commit/0e6fdd58908fd86d924ce040902be4635e90545a	Version Fixed/Implemented In:
Sentry Crash Report:

Description Quinten Kock 2023-06-26 05:16:53 UTC

SUMMARY
When the current song is moved in the playlist (either by moving another song over it, or by moving the song itself), the pause button stops playback, instead of pausing it.

STEPS TO REPRODUCE
1. Play a song in a playlist
2. Move the playing song, or move another song 'over' the playing song, so that its index in the playlist changes
3. Pause

OBSERVED RESULT
Playback stops

EXPECTED RESULT
Playback pauses (Remembers current song and position in song)

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Fedora Linux 38
(available in About System)
KDE Plasma Version: 5.27.5
KDE Frameworks Version: 5.107.0
Qt Version: 5.15.10

ADDITIONAL INFORMATION

Comment 1 Nate Graham 2023-09-14 20:37:05 UTC

Can reproduce.

Comment 2 Bug Janitor Service 2023-09-15 16:42:40 UTC

A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/488

Comment 3 Nate Graham 2023-09-18 16:51:47 UTC

Git commit 0e6fdd58908fd86d924ce040902be4635e90545a by Nate Graham, on behalf of Jack Hill.
Committed on 18/09/2023 at 18:46.
Pushed by ngraham into branch 'master'.

mediaplaylistproxymodel: update playlist indices when moving the current track

Update previous/next track
Update mCurrentPlayListPosition
Emit currentTrackRowChanged
Related: bug 471429, bug 472284

M  +14   -2    src/mediaplaylistproxymodel.cpp
M  +2    -0    src/mediaplaylistproxymodel.h

https://invent.kde.org/multimedia/elisa/-/commit/0e6fdd58908fd86d924ce040902be4635e90545a