Bug 471390

Summary:	conflicting behavior in 'new album' button in `import` flow
Product:	[Applications] digikam	Reporter:	maimed_camping819
Component:	Setup-Collections	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles
Priority:	NOR
Version First Reported In:	8.0.0
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/digikam/-/commit/123966085549e201fd76746fb44e38daae78b9c0	Version Fixed/Implemented In:	8.1.0
Sentry Crash Report:
Attachments:	ui modal to add album fails to pop up

Description maimed_camping819 2023-06-23 15:52:20 UTC

Created attachment 159862 [details]
ui modal to add album fails to pop up

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. close / reopen digikam
2. import --> add folder
3. select a folder
4. without highlighting an existing album, click `new album`
    * nothing happens
6. now highlight any entry in existing albums, and click `new album` again
   * the modal pops up

OBSERVED RESULT
nothing happens

EXPECTED RESULT
the new-album modal pops up even if nothing is selected

Frankly, as a user per the docs and least surprise, i expect to be able to create a new "root" album here (eg something at PEER level to `dummy-album-collection`)

but if that's not possible, and a selection must be made (eg to make a child album), then I should be notified as such rather than silently doing nothing

this only reproduces on the first opening of the dialog, because "parent" album selection appears to be preserved if I close/re-open this add-folder dialog.


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: ubuntu20.04.  
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version:  snap based install, standard repos
Qt Version: 

ADDITIONAL INFORMATION
x11, i3wm

Comment 1 caulier.gilles 2023-06-23 17:17:24 UTC

did you uses Snap package. If yes, the sandbox of this kind of bundle is the problem (Snap is weird here)...

Gilles Caulier

Comment 2 caulier.gilles 2023-06-23 17:19:15 UTC

*** Bug 471394 has been marked as a duplicate of this bug. ***

Comment 3 maimed_camping819 2023-06-23 19:09:38 UTC

https://bugs.kde.org/show_bug.cgi?id=471394  is *not* a duplicate.  I've edited the title here to remove the mention of the "aside" that does discuss a shared topic with 471394

Specifically, in THIS issue, the statement:

> Frankly, as a user per the docs and least surprise, i expect to be able to create a new "root" album here (eg something at PEER level to `dummy-album-collection`)

should be considered an *ASIDE* as feedback about (what appears to be an intentional but confusing design-decision to) not allow interacting with the things that are "*noun*ed" `Album`.

Comment 4 Maik Qualmann 2023-06-23 21:13:36 UTC

Git commit 123966085549e201fd76746fb44e38daae78b9c0 by Maik Qualmann.
Committed on 23/06/2023 at 21:12.
Pushed by mqualmann into branch 'master'.

disable the new album button if no valid album is selected
FIXED-IN: 8.1.0

M  +2    -1    NEWS
M  +13   -2    core/libs/album/widgets/albumselectwidget.cpp
M  +1    -0    core/libs/album/widgets/albumselectwidget.h

https://invent.kde.org/graphics/digikam/-/commit/123966085549e201fd76746fb44e38daae78b9c0

Comment 5 Maik Qualmann 2023-06-23 21:16:44 UTC

Like the OK button, the button for a new album is now disabled until an album is selected. It is not possible to create a new "root" album here. That would be a new collection and can only be created in the setup under Collections.
We don't want to pick just any album at random here either.

Maik