Bug 471297

Summary:	Effect Oldfilm not working on kdenlive
Product:	[Applications] kdenlive	Reporter:	Murilo Ferraz <glilco>
Component:	Video Effects & Transitions	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	normal	CC:	berndmj, iglega, inb-bugzilla-1e1cff, p.r.worrall
Priority:	NOR
Version First Reported In:	23.04.2
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Murilo Ferraz 2023-06-21 14:02:08 UTC

SUMMARY
Effect Oldfilm not working here. I’m using Xubuntu 22.04.2 LTS and kdenlive 23.04.2. I can add the effect to the video clip but nothing changes.


STEPS TO REPRODUCE
1. Open Kdenlive 
2.  Add a video clip to timeline
3.  Add Oldfilm effect to the video
4. Preview the timeline, without changes to the clip

OBSERVED RESULT
No changes to the clip

EXPECTED RESULT
Effect appyed to the clip

SOFTWARE/OS VERSIONS
Linux: Xubuntu 22.04.2 LTS
Kdenlive: 23.04.2

ADDITIONAL INFORMATION
I'm using the ppa install.
Tried to reinstall kdenlive, kdenlive-data and melt and the problem persists, even when removed config files.

When I remove the ppa version and install the version in Xubuntu repository (old version) the effect works.

Comment 1 Paul Worrall 2023-06-25 18:13:50 UTC

*** Bug 471329 has been marked as a duplicate of this bug. ***

Comment 2 Paul Worrall 2023-06-25 18:14:32 UTC

*** Bug 471330 has been marked as a duplicate of this bug. ***

Comment 3 Paul Worrall 2023-06-26 06:47:49 UTC

Running the oldfilm filter from the command line (melt <video.mp4> -filter oldfilm) works OK
Running other MLT filters from within kdenlive (e.g. greyscale) works OK

Comment 4 Bernd 2023-07-05 18:46:39 UTC

I can confirm this for 23.04.2 under Linux (appimage and ppa install) also for the dust effect. Both oldfilm and dust work in 22.12.2

Comment 5 Jean-Baptiste Mardelle 2023-07-11 12:23:20 UTC

Thanks for the report and input. This bug seems to be happening inside MLT. These effects don't work when applied to an MLT chain, but work on MLT producers (MLT recently introduced chain containers for video clips). I will investigate and give feedback asap.

Comment 6 Jean-Baptiste Mardelle 2023-07-11 13:13:48 UTC

I just opened an MLT issue to track the problem:
https://github.com/mltframework/mlt/issues/927

Comment 7 Jean-Baptiste Mardelle 2023-07-20 10:59:21 UTC

Git commit 96d5d34a107d1b64aa9f39ad118befd94e86a9e4 by Jean-Baptiste Mardelle.
Committed on 20/07/2023 at 10:57.
Pushed by mardelle into branch 'release/23.08'.

Initial fix for broken effects caused by switch to MLT chains.

M  +1    -1    data/effects/tracker.xml
M  +4    -0    src/assets/model/assetparametermodel.cpp
M  +4    -0    src/assets/model/assetparametermodel.hpp
M  +0    -1    src/doc/documentvalidator.cpp
M  +25   -0    src/effects/effectstack/model/effectstackmodel.cpp
M  +1    -0    src/jobs/filtertask.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/96d5d34a107d1b64aa9f39ad118befd94e86a9e4

Comment 8 Jean-Baptiste Mardelle 2023-07-22 20:06:21 UTC

Git commit 526e8b33082c74eaabaeb6176d7e98fbd3f6d5e7 by Jean-Baptiste Mardelle.
Committed on 22/07/2023 at 20:06.
Pushed by mardelle into branch 'release/23.08'.

Revert recent change setting in/out on all filters, breaks all keyframable effects

M  +1    -1    data/effects/oldfilm.xml
M  +1    -1    data/effects/tracker.xml
M  +4    -4    src/assets/model/assetparametermodel.cpp
M  +3    -3    src/assets/model/assetparametermodel.hpp
M  +5    -8    src/effects/effectstack/model/effectstackmodel.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/526e8b33082c74eaabaeb6176d7e98fbd3f6d5e7

Comment 9 Paul Worrall 2024-03-07 13:23:09 UTC

Seems to be fixed now (Kdenlive 24.02.0, MLT 7.22.0)