Bug 471173

Summary:	git okular build cmake error at 9f498c7f5
Product:	[Applications] okular	Reporter:	Duncan <1i5t5.duncan>
Component:	general	Assignee:	Okular developers <okular-devel>
Status:	RESOLVED NOT A BUG
Severity:	normal	CC:	kde, nate, sune
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Duncan 2023-06-17 23:22:35 UTC

Okular  (and frameworks5/plasma/many-other-kde-apps) from git, using the gentoo/kde project overlay live-git packages.  Currently reporting 23.07.70 but bugzi's version selector has no git option nor 23.07.70, so unspecified it is.

Yesterday/today I updated to qt 5.15.10 and okular was on the triggered reverse-deps-rebuild list.  At head 0c383d8cf it failed both the initially triggered rebuild and further rebuild attempts after finishing the system update and doing a full smart-live-rebuild (all packages with git updates available, but for okular of course due to this bug).

A bisect points to culprit (emails despammed):
commit 9f498c7f5
Author:     Sune Vuorela <sune@vuo...>
AuthorDate: Thu Apr 20 16:17:41 2023 +0200
Commit:     Nate Graham <nate@...>
CommitDate: Wed Jun 14 17:47:41 2023 +0000

Allow new signatures to have image backgrounds

The reported cmake error is:

CMake Error at generators/poppler/CMakeLists.txt:40 (target_compile_definitions):
Cannot specify compile definitions for target "imageScalingTest" which is
not built by this project.

Note that I have build-testing turned off (Portage's FEATURES=-test, the okular package's USE=-test).  Noting the named imageScalingTest target and assuming testing/CI has testing on suggests a likely testing-option-off logic error.

Comment 1 Duncan 2023-06-17 23:26:45 UTC

CCing author/committer.

Comment 2 Duncan 2023-06-17 23:44:09 UTC

(In reply to Duncan from comment #0)
> commit 9f498c7f5

>  Noting the named imageScalingTest target and
> assuming testing/CI has testing on suggests a likely testing-option-off
> logic error.

Confirmed that testing option logic error.  Setting USE=test (without FEATURES=test it still doesn't actually run the tests) allows it to build.

Comment 3 Duncan 2023-06-18 00:41:42 UTC

Downstream gentoo bug at https://bugs.gentoo.org/908740

Comment 4 Sune Vuorela 2023-06-20 06:30:51 UTC

Gentoo has patched all of the testing of okular and changes in e-c-m. 
https://gitweb.gentoo.org/repo/gentoo.git/tree/kde-apps/okular/files/okular-21.11.80-tests.patch and 
https://gitweb.gentoo.org/repo/gentoo.git/tree/kde-frameworks/extra-cmake-modules/files/extra-cmake-modules-5.93.0-skip-ecm_add_test-early.patch

A new set of tests has been added in a different location and gentoo should adapt their patches.