Bug 470827

Summary: Image Wallpaper delegates show black rectangle instead of preview in folder view settings
Product: [Plasma] plasmashell Reporter: Patrick Silva <bugseforuns>
Component: Image & Slideshow wallpaper pluginsAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: major CC: jr, nate, neon-bugs-null, notmart, qydwhotmail, sitter
Priority: NOR Keywords: qt6
Version First Reported In: master   
Target Milestone: 1.0   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 6.0
Sentry Crash Report:
Attachments: screenshot

Description Patrick Silva 2023-06-09 11:54:08 UTC
Created attachment 159563 [details]
screenshot

STEPS TO REPRODUCE
1. right-click on desktop and choose "Configure folder view..."
2. 
3. 

OBSERVED RESULT
wallpapers without preview, as we can see in the attached screenshot

EXPECTED RESULT
wallpapers with preview

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.27.80
KDE Frameworks Version: 5.240.0
Qt Version: 6.5.0
Graphics Platform: Wayland
Comment 1 Nate Graham 2023-06-09 15:26:00 UTC
Works for me; either a Neon packaging bug, or a "Neon packaging repo being slightly old because it was just fixed recently" issue, or a co-installability of plugin thumbnailers issue. Moving to Neon
Comment 2 Nate Graham 2023-06-12 20:38:21 UTC
I see the problem now. This is working for the slideshow plugin, but not for the Image plugin. Confirmed.
Comment 3 Fushan Wen 2023-07-29 00:38:20 UTC
Git commit b0ce7b083877d0091277d340a4e7317584863872 by Fushan Wen.
Committed on 29/07/2023 at 02:24.
Pushed by fusionfuture into branch 'master'.

wallpapers/image: use property binding for targetSize

Qt6 adds support for property binding in C++. This drops a few
signal-slot usages and makes the code more readable.

M  +1    -1    wallpapers/image/plugin/autotests/test_imagelistmodel.cpp
M  +1    -1    wallpapers/image/plugin/autotests/test_imageproxymodel.cpp
M  +1    -1    wallpapers/image/plugin/autotests/test_packagelistmodel.cpp
M  +1    -1    wallpapers/image/plugin/autotests/test_slidefiltermodel.cpp
M  +1    -1    wallpapers/image/plugin/autotests/test_slidemodel.cpp
M  +3    -7    wallpapers/image/plugin/imagebackend.cpp
M  +3    -2    wallpapers/image/plugin/imagebackend.h
M  +11   -9    wallpapers/image/plugin/model/abstractimagelistmodel.cpp
M  +5    -5    wallpapers/image/plugin/model/abstractimagelistmodel.h
M  +2    -2    wallpapers/image/plugin/model/imagelistmodel.cpp
M  +1    -1    wallpapers/image/plugin/model/imagelistmodel.h
M  +3    -6    wallpapers/image/plugin/model/imageproxymodel.cpp
M  +2    -2    wallpapers/image/plugin/model/imageproxymodel.h
M  +2    -2    wallpapers/image/plugin/model/packagelistmodel.cpp
M  +1    -1    wallpapers/image/plugin/model/packagelistmodel.h
M  +3    -6    wallpapers/image/plugin/slidemodel.cpp
M  +3    -3    wallpapers/image/plugin/slidemodel.h

https://invent.kde.org/plasma/plasma-workspace/-/commit/b0ce7b083877d0091277d340a4e7317584863872
Comment 4 Fushan Wen 2023-07-29 00:38:22 UTC
Git commit d5a29281d6d39425d9b3f687ef10a421a43b01d8 by Fushan Wen.
Committed on 29/07/2023 at 02:24.
Pushed by fusionfuture into branch 'master'.

wallpapers/image: adapt to Plasmoid API change in config dialog
FIXED-IN: 6.0

M  +2    -3    wallpapers/image/imagepackage/contents/ui/config.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/d5a29281d6d39425d9b3f687ef10a421a43b01d8
Comment 5 Fushan Wen 2023-07-29 00:38:31 UTC
Git commit c74af13ec70c3e9415c2ac0147bcf29699af4918 by Fushan Wen.
Committed on 29/07/2023 at 02:24.
Pushed by fusionfuture into branch 'master'.

wallpapers/image: add size valid assertion to find regressions earlier

M  +1    -0    wallpapers/image/plugin/imagebackend.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/c74af13ec70c3e9415c2ac0147bcf29699af4918