| Summary: | Changing font size in text tool does not update the canvas | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Alvin Wong <alvin> |
| Component: | Tool/Text | Assignee: | wolthera <griffinvalley> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | acc4commissions, griffinvalley, keyth2363214 |
| Priority: | NOR | ||
| Version First Reported In: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/-/commit/b3e539c3ede5aa6f8af578ac2e2acd0994181874 | Version Fixed In: | |
| Sentry Crash Report: | |||
I can reproduce. I think it might be caused by font-size adjust.... A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1832 Git commit b3e539c3ede5aa6f8af578ac2e2acd0994181874 by Alvin Wong. Committed on 24/06/2023 at 11:19. Pushed by alvinwong into branch 'master'. Fix font-size-adjust calculation from QTextDocument The previous calculation was wrong, causing text to be stuck in a specific size regardless of the actual font size setting in the rich text editor. When trying to fix it, I found that QFontMetricsF gives bogus values for xHeight (at least on Windows) so it cannot be used. I ended up calculating the value by reading the parameters with FreeType. If the font does not have xHeight, then we just don't write the property. The value of this property is calculated so that the font size of the primary font is the same as when this property is not set. M +18 -3 libs/flake/text/KoSvgTextShapeMarkupConverter.cpp https://invent.kde.org/graphics/krita/-/commit/b3e539c3ede5aa6f8af578ac2e2acd0994181874 *** Bug 465870 has been marked as a duplicate of this bug. *** *** Bug 467848 has been marked as a duplicate of this bug. *** |
SUMMARY Changing font size in text tool does not update the text size on canvas. STEPS TO REPRODUCE 1. Create a new file: 1280x1280 px, 300 ppi 2. Create a text element 3. Set font to "Noto Sans", font size should be "9" by default 4. Input the following text: The quick brown fox jumps over the lazy dog. 5. Click "Save". 6. Change font size to "12" 7. Click "Save". OBSERVED RESULT After changing the font size and pressing "Save" the second time, the line height updates with the new font size, but the text itself is still rendered in the previous font size. EXPECTED RESULT Font size of the text should update. SOFTWARE/OS VERSIONS Windows: Win10 21H2 (19044.2846) Krita: krita-nightly-x64-5.2.0-prealpha-55965ad53a