Bug 470726

Summary: New Page / Page Configuration interfaces looks messy
Product: [Applications] plasma-systemmonitor Reporter: Sikal <sikeal>
Component: generalAssignee: KSysGuard Developers <ksysguard-bugs>
Status: RESOLVED FIXED    
Severity: minor CC: ahiemstra, justin.zobel, nate, plasma-bugs
Priority: NOR    
Version: 5.27.5   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In: 5.27.6
Sentry Crash Report:
Attachments: Screenshot of "New Page" interface

Description Sikal 2023-06-06 23:34:48 UTC
Created attachment 159507 [details]
Screenshot of "New Page" interface

SUMMARY
Some buttons are out of the box.

STEPS TO REPRODUCE
Add a new page
or
On an existing page ; Modify a page > Configure page

OBSERVED RESULT
Some buttons are out of the box and the whole looks bad (no spaces between border of the box and buttons). 

EXPECTED RESULT
A clean box

SOFTWARE/OS VERSIONS
Linux: 6.1.31
KDE Plasma Version: 5.27.5
KDE Frameworks Version: 5.106.0
Qt Version: 5.15.9
Comment 1 Justin Zobel 2023-06-07 02:25:14 UTC
I'm unable to reproduce this issue and I'm on the same version.

The theme appears to be Breeze Dark and I tried with that as well but all text and icons are neatly inside the window.
Comment 2 Sikal 2023-06-07 13:37:53 UTC
After testing, I've noticed that the problem I'm describing only occurs in a Wayland session. Everything is normal under X.Org.
Comment 3 Nate Graham 2023-06-07 20:13:23 UTC
Can reproduce, will fix. The problem only manifests when using a language with strings longer than English, which force the dialog to go into widescreen mode, which triggers these layout bugs, presumably due to not testing the layout with this mode.
Comment 4 Bug Janitor Service 2023-06-07 20:17:49 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/212
Comment 5 Nate Graham 2023-06-07 20:45:49 UTC
Git commit 4391e535fbf4dddb2067702236661dbf02ac2122 by Nate Graham.
Committed on 07/06/2023 at 20:14.
Pushed by ngraham into branch 'master'.

Fix layout of Add New Page dialog with wordy languages

The layout here looked fine in English and languages with shorter
strings English, but broke quite badly with languages that have longer
strings than English when the FormLayout moved into narrow mode, due to
lack of side margins and appropriate height calculation.
FIXED-IN: 5.27.6

M  +10   -2    src/page/PageDialog.qml

https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/4391e535fbf4dddb2067702236661dbf02ac2122
Comment 6 Nate Graham 2023-06-07 20:46:22 UTC
Git commit 6ae7d92ba55963c660e84b719d4ba6864eac7ce1 by Nate Graham.
Committed on 07/06/2023 at 20:46.
Pushed by ngraham into branch 'Plasma/5.27'.

Fix layout of Add New Page dialog with wordy languages

The layout here looked fine in English and languages with shorter
strings English, but broke quite badly with languages that have longer
strings than English when the FormLayout moved into narrow mode, due to
lack of side margins and appropriate height calculation.
FIXED-IN: 5.27.6


(cherry picked from commit 4391e535fbf4dddb2067702236661dbf02ac2122)

M  +10   -2    src/page/PageDialog.qml

https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/6ae7d92ba55963c660e84b719d4ba6864eac7ce1