Bug 470723

Summary:	Haruna does not pick up the audio track with youtube-dl
Product:	[Applications] Haruna	Reporter:	Peter <sunspark>
Component:	generic	Assignee:	george fb <georgefb899>
Status:	RESOLVED FIXED
Severity:	normal	CC:	justin.zobel
Priority:	NOR
Version First Reported In:	0.11.1
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Peter 2023-06-06 21:57:45 UTC

SUMMARY
Regular video files play with audio, but if one attempts to use the youtube-dl functionality of Haruna, only the video and subtitle tracks are available, not audio. No audio track is listed as present.

STEPS TO REPRODUCE
1. Provide Haruna with any youtube url to play.

OBSERVED RESULT
Video plays in silence.

EXPECTED RESULT
Video to play with sound.

SOFTWARE/OS VERSIONS
Operating System: SteamOS 3.4.6
KDE Plasma Version: 5.26.1
KDE Frameworks Version: 5.99.0
Qt Version: 5.15.6
Kernel Version: 5.13.0-valve36-1-neptune (64-bit)
Graphics Platform: X11

ADDITIONAL INFORMATION
Haruna settings for youtube-dl has not been changed from the default of custom "bestvideo+bestaudio/best". Not sure if this is literally youtube-dl, but if so, youtube-dl is defunct and starting to break and this should be changed instead to yt-dlp: https://github.com/yt-dlp/yt-dlp

Comment 1 Justin Zobel 2023-06-07 02:30:15 UTC

I have tested this and Fedora and I get sound with the video. I have the default settings and the same Haruna version as you 0.11.1 but newer Plasma/Frameworks/Qt.

Is your system fully up to date?

Comment 2 Peter 2023-06-07 23:03:06 UTC

(In reply to Justin Zobel from comment #1)
> I have tested this and Fedora and I get sound with the video. I have the
> default settings and the same Haruna version as you 0.11.1 but newer
> Plasma/Frameworks/Qt.
> 
> Is your system fully up to date?

I guess.. it's what Valve ships currently. The thing is though, on Windows with both youtube-dl and yt-dlp there is audio, just not with the flatpak version of Haruna here.

Maybe there is a difference between the Fedora offering (if you're using their repository) and what the discover store flatpak provides?

Comment 3 Justin Zobel 2023-06-07 23:44:43 UTC

The Flatpak from Flathub which I think is what the Steam Deck uses (you can check in Discover Settings) uses yt-dlp as per the manifest here https://github.com/flathub/org.kde.haruna/blob/master/org.kde.haruna.yml

I've checked on my laptop where I use the Haruna Flatpak from Flathub and that works just fine. 🤔

Comment 4 george fb 2023-06-08 00:02:07 UTC

I can reproduce. Doesn't happen with all videos though and only with flatpak version.

Comment 5 Justin Zobel 2023-06-08 01:39:46 UTC

Setting to confirmed.

Comment 6 george fb 2023-06-08 17:14:30 UTC

I updated the flatpak to use an older version of yt-dlp which doesn't have this problem (hopefully, I only tested one video).

Comment 7 Peter 2023-06-08 20:55:53 UTC

I tested with 2 videos, looks fixed now!

Comment 8 Justin Zobel 2023-06-09 02:17:48 UTC

Fixed in Flatpak by George.