Bug 470583

Summary: Nothing happens after clicking on the update notifier
Product: [Applications] Discover Reporter: Patrick Silva <bugseforuns>
Component: NotifierAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED DUPLICATE    
Severity: normal CC: aleixpol, faure, nate, nicolas.fella, publiclyvisibleemail
Priority: NOR Keywords: qt6
Version: master   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed In:

Description Patrick Silva 2023-06-03 11:04:39 UTC
STEPS TO REPRODUCE
1. click on the update notifier in the system tray
2. 
3. 

OBSERVED RESULT
nothing happens

EXPECTED RESULT
Discover opens

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.27.80
KDE Frameworks Version: 5.240.0
Qt Version: 6.5.0
Graphics Platform: Wayland
Comment 1 Nate Graham 2023-06-03 17:44:24 UTC
This is working for me. I suspect a Neon packaging issue. Can you kill DiscoverNotifier, run it in a terminal window, and then print the output when you click on its System Tray icon?
Comment 2 Patrick Silva 2023-06-03 18:26:19 UTC
I see these messages after running the notifier:

$ /usr/lib/x86_64-linux-gnu/libexec/DiscoverNotifier
qt.dbus.integration: Could not connect "org.freedesktop.NetworkManager" to "stateChanged"
qt.dbus.integration: Could not connect "org.freedesktop.NetworkManager" to "connectivityChanged"
qt.dbus.integration: Could not connect "org.freedesktop.NetworkManager" to "deviceTypeChanged"
qt.dbus.integration: Could not connect "org.freedesktop.NetworkManager" to "meteredChanged"

Nothing else appears after click on its system tray icon.
Comment 3 Nate Graham 2023-06-03 18:32:38 UTC
Interesting. Does Discover launch normally from e.g. Kickoff or KRunner?
Comment 4 Patrick Silva 2023-06-03 18:37:10 UTC
yes
Comment 5 Nate Graham 2023-06-06 15:57:39 UTC
Ok, so Discover launches on its own, and the Notifier is interactive. There must be an issue with the way the Notifier is launching Discover for you. When clicked, it's running `plasma-discover --mode update`. Can you try that in a Terminal window?

Also, if you right-click on the Discover Notifier icon, do any of the menu items in its context menu do anything?
Comment 6 Patrick Silva 2023-06-06 16:22:29 UTC
Nothing happens after right-click in the system tray icon.
Your command opens Discover with "Update" page focused.
Comment 7 Nate Graham 2023-06-06 16:27:31 UTC
Okay, next question: does `kioclient exec file:/usr/share/applications/org.kde.discover.desktop` do anything?
Comment 8 Patrick Silva 2023-06-06 16:31:25 UTC
(In reply to Nate Graham from comment #7)
> Okay, next question: does `kioclient exec
> file:/usr/share/applications/org.kde.discover.desktop` do anything?

Discover opens with Home focused.
Comment 9 Nate Graham 2023-06-06 16:38:35 UTC
All right, thanks.

Well, I'm stumped. These exact lines of code in DiscoverNotifier.cpp are what's failing for Patrick (Neon Unstable), but they work for me (Self-compiled Discover on Fedora 38):


    auto *job = new KIO::CommandLauncherJob(QStringLiteral("plasma-discover"), {QStringLiteral("--mode"), QStringLiteral("update")});
    job->setUiDelegate(new KNotificationJobUiDelegate(KJobUiDelegate::AutoErrorHandlingEnabled));
    job->setDesktopName(QStringLiteral("org.kde.discover"));
    job->setStartupId(xdgActivationToken.toUtf8());
    job->start();

    auto *job = new KIO::ApplicationLauncherJob(KService::serviceByDesktopName(QStringLiteral("org.kde.discover")));
    job->setStartupId(xdgActivationToken.toUtf8());
    job->setUiDelegate(new KNotificationJobUiDelegate(KJobUiDelegate::AutoErrorHandlingEnabled));
    job->start();


Any ideas how to proceed here, Nico?
Comment 10 Patrick Silva 2023-06-30 11:47:58 UTC
This bug affects the systray icon of any app. Nothing happens after left/right/middle click on the systray icon of Discord, OBS Studio and Strawberry player, for example.
Comment 11 Patrick Silva 2023-07-02 15:52:28 UTC
*** Bug 471876 has been marked as a duplicate of this bug. ***
Comment 12 Nate Graham 2023-07-16 10:24:10 UTC
Is it working now, or still broken for all apps' tray icons?
Comment 13 Patrick Silva 2023-07-26 12:42:57 UTC
It's still broken for all apps' tray icons.
Comment 14 Nate Graham 2023-07-26 18:55:49 UTC
Then let's track it in Bug 472003, because there's no indication here that Discover in particular is doing anything wrong. I don't see any defects in the code that could explain this.

*** This bug has been marked as a duplicate of bug 472003 ***
Comment 15 David Faure 2023-12-27 19:23:16 UTC
(In reply to Patrick Silva from comment #2)
> I see these messages after running the notifier:
> 
> $ /usr/lib/x86_64-linux-gnu/libexec/DiscoverNotifier
> qt.dbus.integration: Could not connect "org.freedesktop.NetworkManager" to
> "stateChanged"
> qt.dbus.integration: Could not connect "org.freedesktop.NetworkManager" to
> "connectivityChanged"
> qt.dbus.integration: Could not connect "org.freedesktop.NetworkManager" to
> "deviceTypeChanged"
> qt.dbus.integration: Could not connect "org.freedesktop.NetworkManager" to
> "meteredChanged"

Those warnings are harmless. I just fixed them in https://codereview.qt-project.org/c/qt/qtbase/+/527739 though.