Bug 470345

Summary: Configuring toolbars in KF6-ported apps fails
Product: [Frameworks and Libraries] frameworks-kxmlgui Reporter: Nate Graham <nate>
Component: generalAssignee: kdelibs bugs <kdelibs-bugs-null>
Status: RESOLVED FIXED    
Severity: major CC: justin.zobel, nicolas.fella
Priority: NOR Keywords: qt6
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=470574
Latest Commit: https://invent.kde.org/frameworks/kxmlgui/-/commit/9ee32413240e4e0a48bd8708f52cf2c08a54675b Version Fixed/Implemented In:
Sentry Crash Report:

Description Nate Graham 2023-05-28 03:58:22 UTC 
STEPS TO REPRODUCE
1. Open a KF6-ported QtWidgets-based KXMPGUI-using app, such as Dolphin, Gwenview or Konsole
2. Right-click on toolbar and see no "Configure Toolbars" menu item
3. Click hamburger menu > Configure > Configure toolbars
4. Edit the toolbar layout in some way and press OK or Apply


OBSERVED RESULT
Toolbar visually flickers for a moment, but the requested change is not made. If you close the toolbar configuration window and open it again, the changes you just made have been lost


EXPECTED RESULT
Toolbar configuration works as normal like it still does in KF5-using apps such as Ark


ADDITIONAL INFORMATION
After performing the steps to reproduce, if you deliberately open the KF5 version of the app, the changes you made to its toolbar in the KF6 version are reflected there.


SOFTWARE/OS VERSIONS
Operating System: Fedora Linux 38
KDE Plasma Version: 5.27.80
KDE Frameworks Version: 5.240.0
Qt Version: 6.5.0
Kernel Version: 6.2.15-300.fc38.x86_64 (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Core™ i7-10510U CPU @ 1.80GHz
Memory: 15.2 GiB of RAM
Graphics Processor: Mesa Intel® UHD Graphics
Comment 1 Justin Zobel 2023-06-03 04:02:55 UTC 
Can confirm both issues, lack of configure in right-click and no change to the toolbar apart from flicker when configuring via the hamburger menu.
Comment 2 Nicolas Fella 2023-07-07 11:40:57 UTC 
> 2. Right-click on toolbar and see no "Configure Toolbars" menu item

https://bugs.kde.org/show_bug.cgi?id=471978
Comment 4 Nicolas Fella 2023-07-07 18:20:55 UTC 
Git commit 9ee32413240e4e0a48bd8708f52cf2c08a54675b by Nicolas Fella.
Committed on 07/07/2023 at 11:55.
Pushed by nicolasfella into branch 'master'.

Fix rc file lookup

The dir is still kxmlgui5 almost everywhere and hasn't been migrated to 6

Only one place was adjusted, breaking the lookup
Related: bug 470574

M  +1    -1    src/kxmlguiclient.cpp

https://invent.kde.org/frameworks/kxmlgui/-/commit/9ee32413240e4e0a48bd8708f52cf2c08a54675b