| Summary: | Elisa should not be so restrictive regarding names of cover art | ||
|---|---|---|---|
| Product: | [Applications] Elisa | Reporter: | Knut Hildebrandt <post> |
| Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
| Status: | CONFIRMED --- | ||
| Severity: | wishlist | CC: | nate |
| Priority: | NOR | ||
| Version First Reported In: | 23.04.0 | ||
| Target Milestone: | --- | ||
| Platform: | Manjaro | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Knut Hildebrandt
2023-05-25 09:05:25 UTC
Probably a sane idea. Maybe when there are multiple image files, we can apply the current naming restrictions to choose one. But when there's only one image file, we should just use that. (In reply to Nate Graham from comment #1) > Probably a sane idea. Maybe when there are multiple image files, we can apply the current naming restrictions to choose one. But when there's only one image file, we should just use that. If you apply the restriction in case of multiple image files we might end up with not showing any too. Particularly directories containing sampler often have one image per music file, the one of the original disc or record. I've also seen directories with all artwork like front cover, back cover booklet etc. and often more than one of these files carries the word cover in its name. Which to choose? Thus I'd propose to offer a dialogue to choose one of these files. Another great feature would be a search function for cover art as it is implemented in other music players. Should I open another issue for this? Yes, that's a good point. In case nothing matches, maybe we should just take the one that matches the name of the album, or if not, the song, or if not, just the alphabetically first one. Git commit 85c29dcbff4b6ddd41bf852220fbf30112c06218 by Nate Graham, on behalf of Jack Hill. Committed on 27/06/2023 at 19:38. Pushed by ngraham into branch 'master'. If there is a single image in an album folder, use that as the cover file regardless of the name of the image. R +- -- autotests/data/cover_art/artist1/album1/image_file.jpg [from: autotests/data/cover_art/artist1/album1/cover.jpg - 100% similarity] R +0 -0 autotests/data/cover_art/artist1/album1/image_file.jpg.license [from: autotests/data/cover_art/artist1/album1/cover.jpg.license - 100% similarity] M +3 -1 autotests/filescannertest.cpp M +8 -1 src/filescanner.cpp https://invent.kde.org/multimedia/elisa/-/commit/85c29dcbff4b6ddd41bf852220fbf30112c06218 Git commit ff8dc3a2e71fae4429d5a295050d889a0460c5d3 by Nate Graham, on behalf of Jack Hill. Committed on 27/06/2023 at 19:38. Pushed by ngraham into branch 'master'. Use the first alphabetically found image file for cover image as a last resort C +- -- autotests/data/cover_art/artist2/album1/image1.png [from: autotests/data/cover_art/artist2/album1/Folder.png - 100% similarity] C +0 -0 autotests/data/cover_art/artist2/album1/image1.png.license [from: autotests/data/cover_art/artist2/album1/Folder.png.license - 100% similarity] R +- -- autotests/data/cover_art/artist2/album1/image2.png [from: autotests/data/cover_art/artist2/album1/Folder.png - 100% similarity] R +0 -0 autotests/data/cover_art/artist2/album1/image2.png.license [from: autotests/data/cover_art/artist2/album1/Folder.png.license - 100% similarity] M +4 -1 autotests/filescannertest.cpp M +5 -0 src/filescanner.cpp https://invent.kde.org/multimedia/elisa/-/commit/ff8dc3a2e71fae4429d5a295050d889a0460c5d3 |