Bug 470110

Summary: File Layer not resizing correctly when the canvas size is changed
Product: [Applications] krita Reporter: Dynline <saranvale>
Component: Resize/Scale Image/LayerAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: griffinvalley, zoomulator
Priority: NOR    
Version: 5.1.5   
Target Milestone: ---   
Platform: Other   
OS: Other   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Dynline 2023-05-22 08:02:04 UTC
SUMMARY

***
I noticed that file layers will not resize or keep the transform position when I either resize the document or export to a different size. There is a few ways to see this behaviour, I will list all below. 
***

STEPS TO REPRODUCE


Case 1
1.  Drag and drop a new file layer in the canvas
2. File > export advanced> pick jpg or png
3.  in te resize tab put a lower pixel size
4. check the file layer remaining the same size but being cropped instead of scaling down

Case 2 
1.  Drag and drop a new file layer in the canvas
2. Add a transform mask to that file layer
3. move the image in a new position (try upper right corner of the canvas for example)
4. File > export advanced> pick jpg or png 
5.  in the resize tab put a lower pixel size (for example 1920*1080 down to 500*281, put a way lower size to see the problem better)
6. See how the file layer seem to keep the position but still a bigger size and is cropped outside the canvas

Case 3 
1.  Drag and drop a new file layer in the canvas
2. Add a transform mask to that file layer
3. move the image in a new position
4. image> scale Image to new size
5.  in te resize tab put a lower pixel size (for example 1920*1080 down to 500*281)
6. See how the file layer seem to keep the position but still a bigger size and is cropped outside the canvas>


OBSERVED RESULT
The image stays the same size and does not scale or move with the canvas.

EXPECTED RESULT
Image and transform mask to scale proportionally with the new size and keep the position within the canvas.

SOFTWARE/OS VERSIONS
Windows: 10

ADDITIONAL INFORMATION
Additional steps of CASE 3 I just discovered
7. Ctrl+z the scale change to the canvas you just made
8. See how the file layer with transform mask is not in the upper right corner anymore and you have to reposition it.

It seems the problem is related to both file layers not scaling and transform masks not keeping their position after a canvas resize.
Comment 1 wolthera 2023-10-18 12:21:43 UTC
Thanks, I can confirm.
Comment 2 wolthera 2023-10-18 12:38:04 UTC
*** Bug 467257 has been marked as a duplicate of this bug. ***
Comment 3 Dmitry Kazakov 2024-08-23 13:21:37 UTC
Git commit 91aa790cab80fac35b62bd96b8b9f15e92d1bc8b by Dmitry Kazakov.
Committed on 23/08/2024 at 13:21.
Pushed by dkazakov into branch 'master'.

Make sure file layers are updated when image size or resolution changes
Related: bug 467257

M  +29   -0    libs/ui/kis_file_layer.cpp
M  +5    -0    libs/ui/kis_file_layer.h

https://invent.kde.org/graphics/krita/-/commit/91aa790cab80fac35b62bd96b8b9f15e92d1bc8b
Comment 4 Dmitry Kazakov 2024-08-27 06:58:11 UTC
Git commit c554def57cde7aad7835d3245d678548cae3eaf0 by Dmitry Kazakov.
Committed on 27/08/2024 at 06:57.
Pushed by dkazakov into branch 'krita/5.2'.

Make sure file layers are updated when image size or resolution changes
Related: bug 467257

M  +29   -0    libs/ui/kis_file_layer.cpp
M  +5    -0    libs/ui/kis_file_layer.h

https://invent.kde.org/graphics/krita/-/commit/c554def57cde7aad7835d3245d678548cae3eaf0