| Summary: | Hints are not working correctly in the Freecell game mode | ||
|---|---|---|---|
| Product: | [Applications] kpat | Reporter: | winblocker |
| Component: | solver | Assignee: | Stephan Kulow <coolo> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aacid, anna, kde-games-bugs-null, sjurberengal+kde |
| Priority: | NOR | ||
| Version First Reported In: | 23.04.1 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/games/kpat/-/commit/31aa7a28cb63c9d7be35371a63ec2f481bec6efe | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | wrong highlight | ||
Stephan, git bisect says that https://invent.kde.org/games/kpat/-/commit/f15e0e5f767beb1c2d6f2ea0b32ef4610b3fc994 is what broke it. Can you have a look? 469368 liked it! :) This is trickier than I thought. Freecell solvers will basically only emit hints from winning moves and people expect this by now. But I can't implement this globally as most other games/solvers are just too slow to wait for them. But I reverted the regression and fixed simple simon autodrop differently: https://invent.kde.org/games/kpat/-/merge_requests/50 *** Bug 469082 has been marked as a duplicate of this bug. *** *** Bug 468933 has been marked as a duplicate of this bug. *** Git commit cc62c5599a7bd586ec94f874ab89efc50253d60c by Albert Astals Cid, on behalf of Stephan Kulow.
Committed on 12/06/2023 at 21:24.
Pushed by aacid into branch 'master'.
Solve the simple simon autodrop problem less aggressively
Using the brute force algorithm for auto drop has several drawbacks
that users reported:
- it's too aggressive (didn't matter for simple simon when I implemented
it, as there is only one kind of foundation move)
- the hint function is no longer a way to cheat your scores, you actually
need to pick the winning move yourself
So revert that part and make in return the simple simon solver more useful
for autodrop by providing the right priority for foundation moves. In addition
I had to make sure we always return a first move even if the old interface
is not implemented.
M +0 -5 src/dealer.cpp
M +12 -2 src/patsolve/abstract_fc_solve_solver.cpp
M +1 -1 src/patsolve/abstract_fc_solve_solver.h
M +4 -2 src/patsolve/simonsolver.cpp
M +0 -15 src/patsolve/simonsolver.h
https://invent.kde.org/games/kpat/-/commit/cc62c5599a7bd586ec94f874ab89efc50253d60c
Git commit 31aa7a28cb63c9d7be35371a63ec2f481bec6efe by Albert Astals Cid, on behalf of Stephan Kulow.
Committed on 12/06/2023 at 21:38.
Pushed by aacid into branch 'release/23.04'.
Solve the simple simon autodrop problem less aggressively
Using the brute force algorithm for auto drop has several drawbacks
that users reported:
- it's too aggressive (didn't matter for simple simon when I implemented
it, as there is only one kind of foundation move)
- the hint function is no longer a way to cheat your scores, you actually
need to pick the winning move yourself
So revert that part and make in return the simple simon solver more useful
for autodrop by providing the right priority for foundation moves. In addition
I had to make sure we always return a first move even if the old interface
is not implemented.
(cherry picked from commit cc62c5599a7bd586ec94f874ab89efc50253d60c)
M +0 -5 src/dealer.cpp
M +12 -2 src/patsolve/abstract_fc_solve_solver.cpp
M +1 -1 src/patsolve/abstract_fc_solve_solver.h
M +4 -2 src/patsolve/simonsolver.cpp
M +0 -15 src/patsolve/simonsolver.h
https://invent.kde.org/games/kpat/-/commit/31aa7a28cb63c9d7be35371a63ec2f481bec6efe
|
Created attachment 159099 [details] wrong highlight SUMMARY Using the "Hint" feature highlights all cards instead of the appropriate in the "Freecell" game mode. STEPS TO REPRODUCE 1. Open kpat 2. Select "Freecell" game mode 3. Press "H" for hint OBSERVED RESULT All cards are highlighted EXPECTED RESULT Only logical steps provided by the solver should be highlighted SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.27.5 KDE Frameworks Version: 5.106.0 Qt Version: 5.15.9 Kernel Version: 6.3.2-arch1-1 (64-bit) Graphics Platform: Wayland Processors: 32 × AMD Ryzen 9 5950X 16-Core Processor Memory: 31.3 GiB of RAM Graphics Processor: AMD Radeon RX 6900 XT ADDITIONAL INFORMATION