| Summary: | Can no longer use the up arrow to edit the last message | ||
|---|---|---|---|
| Product: | [Applications] NeoChat | Reporter: | Justin Zobel <justin.zobel> |
| Component: | General | Assignee: | Tobias Fella <fella> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | carl |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/network/neochat/-/commit/ee53793a6daeb8bc2bc2f9a5918ca3604ae49c3d | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Justin Zobel
2023-05-14 08:41:52 UTC
A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/1016 Git commit ee53793a6daeb8bc2bc2f9a5918ca3604ae49c3d by James Graham. Committed on 27/05/2023 at 16:36. Pushed by nvrwhere into branch 'master'. Fix replying and editing from chatbox Restore the functionality to edit or reply to the last message in the `chatbar`. This is achieved be moving the functions `getLastLocalUserMessageEventId` and `getLatestMessageFromRow` to `NeoChatRoom` as `editLastMessage` and `replyLastMessage` as `chatbar` no longer has access to `messageEventModel`. The functions are also simplified as they only need to find the `eventId` and always from row 0 as this was the only use of the functions. M +0 -81 src/models/messageeventmodel.cpp M +0 -25 src/models/messageeventmodel.h M +67 -0 src/neochatroom.cpp M +15 -0 src/neochatroom.h M +2 -8 src/qml/Component/ChatBox/ChatBar.qml https://invent.kde.org/network/neochat/-/commit/ee53793a6daeb8bc2bc2f9a5918ca3604ae49c3d |