| Summary: | In Volume OSD, "100%" volume string is a multi-line string | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Maximilian Böhm <mabo> |
| Component: | Theme - Breeze | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | boredsquirrel, bugs_kde_org.5.kuru, isma.af, kde, mabo, nate, nicolas.fella, postix, visual-design |
| Priority: | HI | Keywords: | regression |
| Version First Reported In: | 5.27.5 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/94b2c3d1d4a72d70d487513954601c2cf723e673 | Version Fixed In: | 5.27.8 |
| Sentry Crash Report: | |||
| Attachments: | Double rowed 100% indicator | ||
(My second problem in this ticket with missing plop sound is resolved: Notification sound was set silent.) *** Bug 469759 has been marked as a duplicate of this bug. *** Well that's weird. Never seen that before. Probably a width calculation rounding error somewhere that only happens when using certain fractional scale factors. Not only 162,5% is affected but also simple integer 200% scaling as I mentioned in my dup bug report. I use 200% scale myself and FWIW, have never seen this with either 10pt Noto Sans or 11pt Noto Sans, on either X11 or Wayland. (In reply to Nate Graham from comment #5) > I use 200% scale myself and FWIW, have never seen this with either 10pt Noto > Sans or 11pt Noto Sans, on either X11 or Wayland. 200% scale, 10pt Noto Sans and to go sure it's not a caching issue, I have emptied `~/.cache/` and rebooted, but the issue still persists. However, I can reproduce it with any scaling, e.g. 100% or 150%. Thus it doesn't seem to be related to _a_ scaling factor. Also cannot remember to have ever seen it on 5.27.4 or prior, therefore I have added the regression keyword. I cannot reproduce the issue when having a 200% scaling and Noto Sans <= 5pt, but for Noto Sans >= 6 pt. My comments only regard the Wayland session. *** Bug 469943 has been marked as a duplicate of this bug. *** This is caused by https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2795 With the translations fixed the string now is e.g. "110 %" while before the untranslated string was "110%" (note the space between the number and percent). Whether you are affected by this therefore depends on your language A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2935 (In reply to Nicolas Fella from comment #9) > This is caused by > https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2795 > > With the translations fixed the string now is e.g. "110 %" while before the > untranslated string was "110%" (note the space between the number and > percent). Whether you are affected by this therefore depends on your language In case the translation has both a space in the actual string and the fixed "maximum string" "100 %" (which is a fair assumption), it might be an issue with `TextMetrics.width`, which has shown some problems in the past, specially when measuring whitespaces (example: https://bugs.kde.org/show_bug.cgi?id=421973 and https://invent.kde.org/system/dolphin/-/merge_requests/22). Usually `advanceWidth` provides a better value *** Bug 470377 has been marked as a duplicate of this bug. *** Git commit 9737efa79440b65db303030f34f0039f1c9cd6a0 by Kai Uwe Broulik. Committed on 01/08/2023 at 21:24. Pushed by broulik into branch 'master'. OSD: Fix size calculation for progress value Use a common function for formatting the percent, so placeholder 100% label will use the exact formatting used by the label next to the progress bar. Also use font advanceWidth, which is the appropriate means of calculating the bounding box of text in this case. Also ceil it to avoid subpixel alignment. And to be absolutely sure disable word wrapping. M +8 -3 lookandfeel/org.kde.breeze/contents/osd/OsdItem.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/9737efa79440b65db303030f34f0039f1c9cd6a0 Git commit 94b2c3d1d4a72d70d487513954601c2cf723e673 by Kai Uwe Broulik. Committed on 01/08/2023 at 21:41. Pushed by fvogt into branch 'Plasma/5.27'. OSD: Fix size calculation for progress value Use a common function for formatting the percent, so placeholder 100% label will use the exact formatting used by the label next to the progress bar. Also use font advanceWidth, which is the appropriate means of calculating the bounding box of text in this case. Also ceil it to avoid subpixel alignment. And to be absolutely sure disable word wrapping. (cherry picked from commit 9737efa79440b65db303030f34f0039f1c9cd6a0) M +8 -3 lookandfeel/org.kde.breeze/contents/osd/OsdItem.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/94b2c3d1d4a72d70d487513954601c2cf723e673 |
Created attachment 158826 [details] Double rowed 100% indicator Right after the Plasma 5.27.5 release I found that the 100% volume indicator notification now is double-rowed. I’m using 162,5% UI scale on X.org. See the screenshot. Apart from this visual bug, the auditive plop sound is missing too but I guess this is such a striking issue that someone will fix this without a separate bug report. KDE Plasma Version: 5.27.5 KDE Frameworks Version: 5.105.0 Qt Version: 5.15.9