Summary: | 7c91c4bad9ee709eebfdf9d5b3997fa00ca7cd13 causes cursor to not snap back to center in Minecraft | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | kocelfc |
Component: | input | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | emozdemir, maciej.stanczew, sirenji404 |
Priority: | NOR | ||
Version: | 5.27.5 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/kwin/commit/3d62e7548955e2ddf298c61a55fcd26007ea27bb | Version Fixed In: | |
Sentry Crash Report: |
Description
kocelfc
2023-05-09 22:34:39 UTC
Do you know if this issue is reproducible in other wayland desktop environments (e.g. gnome shell)? I just tested a fresh Fedora 38 ISO with GNOME 44.1 and it is not reproducible there. Same bug happens in Apex Legends too. On X11 it works as intended. Pointer's position expected to reposition to the center of the game when opening an interactable menu (inventory, deathboxes, esc menu, blackmarket etc.). With this new commit pointer stays where it was before. Similar issue in Diablo III: 1. Open the item inventory 2. Pick up any item by left-clicking → this will make the cursor disappear 3. Move to a different item slot 4. Drop the item → this will make the cursor appear again Before, the cursor would appear at the item's new location, as it's supposed to. After 7c91c4bad9ee709eebfdf9d5b3997fa00ca7cd13, the cursor appears in the previous location (where the item was picked up instead of dropped). Reverting d7033a3c83134f383fbbd8e005ff6a10c79e48d4 from Plasma/5.27 branch makes the issue go away. Same with Hearthstone: when clicking a card (cursor disappears), moving it around the game board, and then releasing, the cursor will reappear back at the position where the card was initially clicked, instead of where it was released. Can somebody test whether https://invent.kde.org/-/snippets/2650 fixes the issue? (In reply to Vlad Zahorodnii from comment #6) > Can somebody test whether https://invent.kde.org/-/snippets/2650 fixes the > issue? I think this is the previous expression. I don't know how to exactly apply the patch but this should work. It only partially reverts 7c91c4bad9ee709eebfdf9d5b3997fa00ca7cd13. Also, are there other affected games? Ideally, free ones and that don't need a lot of disk space It appears Apex Legends is a free one, but it requires a lot of disk space (and I presume requires a lot of time to download it depending on the internet connection) As Maciej says Hearthstone has an issue because of this commit too. It's a smaller game compared to Apex and can be installed through Lutris. A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/4094 Git commit 07da1796b8388b00275d8281fac476bde71cd02b by Vlad Zahorodnii. Committed on 11/05/2023 at 19:56. Pushed by vladz into branch 'master'. Revert "wayland: Avoid pointer warp if constraint region is invalid" This reverts commit 7c91c4bad9ee709eebfdf9d5b3997fa00ca7cd13. It created regressions in some video games. After a closer look at the pointer constraint region handling, there are some issues, but it might be safer to fix them in master. In meanwhile, let's revert 7c91c4bad because it breaks more things than it fixes. Related: bug 457021 M +2 -2 src/pointer_input.cpp https://invent.kde.org/plasma/kwin/commit/07da1796b8388b00275d8281fac476bde71cd02b Git commit 3d62e7548955e2ddf298c61a55fcd26007ea27bb by Vlad Zahorodnii. Committed on 12/05/2023 at 06:26. Pushed by vladz into branch 'Plasma/5.27'. Revert "wayland: Avoid pointer warp if constraint region is invalid" This reverts commit 7c91c4bad9ee709eebfdf9d5b3997fa00ca7cd13. It created regressions in some video games. After a closer look at the pointer constraint region handling, there are some issues, but it might be safer to fix them in master. In meanwhile, let's revert 7c91c4bad because it breaks more things than it fixes. Related: bug 457021 (cherry picked from commit 07da1796b8388b00275d8281fac476bde71cd02b) M +2 -2 src/pointer_input.cpp https://invent.kde.org/plasma/kwin/commit/3d62e7548955e2ddf298c61a55fcd26007ea27bb > Can somebody test whether https://invent.kde.org/-/snippets/2650 fixes the issue? It fixes the issue for me in Hearthstone, but not in Diablo III. Only the full revert makes it work. > Also, are there other affected games? Ideally, free ones and that don't need a lot of disk space At first I assumed any game which temporarily hides the mouse cursor would be impacted. But then I checked a couple other games, both native as well as running through Wine/Proton, and didn't see this issue. Maybe other people can comment with more affected games? *** Bug 470028 has been marked as a duplicate of this bug. *** |