Bug 469219

Summary: other text in the 'Configure' for 'Auto save ...'
Product: [Applications] kate Reporter: pierre-yves
Component: generalAssignee: KWrite Developers <kwrite-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: christoph, p.r.worrall
Priority: NOR    
Version First Reported In: 22.12.3   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description pierre-yves 2023-05-01 05:00:10 UTC
In 'Configure' in 'Open/Save' there is this text:
'Auto save document when focus leaves the editor'

I would change the text because when I tab-browse, the editor is still in focus but it does save the document.
So I would change the text like this:
'Auto save document when the active tab is not in focus any more'
Comment 1 pierre-yves 2023-05-01 06:03:30 UTC
Or this is maybe even better:
'Auto save document when the active tab of the editor is not in focus any more'
Comment 2 pierre-yves 2023-05-01 06:20:08 UTC
I think that this is the best:
'Auto save document when the active tab of the editor is losing focus'
Comment 3 Christoph Cullmann 2023-05-20 19:15:27 UTC
That is a message in the library code, we don't know it the view is in some tab.

Would 'Auto save document when focus leaves the current editor view' be good, too?
Comment 4 pierre-yves 2023-05-21 07:47:04 UTC
>Would 'Auto save document when focus leaves the current editor view' be good, too?

No, because even if the current editor view stays in focus, it does save documents during tab-browsing in the current editor view.
Comment 5 Christoph Cullmann 2023-06-29 17:43:25 UTC
(In reply to pierre-yves from comment #4)
> >Would 'Auto save document when focus leaves the current editor view' be good, too?
> 
> No, because even if the current editor view stays in focus, it does save
> documents during tab-browsing in the current editor view.

Ok, then please provide a different variant, as said, one can disable tabs and still have multiple views, therefore we can't just say tab.
Comment 6 pierre-yves 2023-07-01 14:03:36 UTC
'Auto save document when the active document of the editor is losing focus'
Comment 7 pierre-yves 2023-07-01 14:07:52 UTC
Or this is maybe even better:

'Auto save document when the active document is losing focus'
Comment 8 Christoph Cullmann 2023-07-01 14:41:18 UTC
Git commit 56b1a1e1051b9738b12722af5e50bf796e1eab05 by Christoph Cullmann.
Committed on 01/07/2023 at 14:41.
Pushed by cullmann into branch 'master'.

improve auto save description

M  +1    -1    src/dialogs/opensaveconfigwidget.ui

https://invent.kde.org/frameworks/ktexteditor/-/commit/56b1a1e1051b9738b12722af5e50bf796e1eab05
Comment 9 Christoph Cullmann 2023-07-01 14:41:46 UTC
Thanks for providing the text.