Bug 469176

Summary: Data from wrong filter is appended/loaded if navigation item is switched in notifications
Product: [Applications] Tokodon Reporter: Shubham Arora <shubhamarora>
Component: generalAssignee: Unassigned bugs mailing-list <unassigned-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: carl, josh
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Video of Issue.

Description Shubham Arora 2023-04-30 07:58:19 UTC
Created attachment 158553 [details]
Video of Issue.

SUMMARY
Data from wrong filter is appended/loaded if navigation item is switched in notifications while the previous filter is loading. 

STEPS TO REPRODUCE
1. Open Notification.
2. While the data is loading switch the navigation to change the filter.

OBSERVED RESULT
1. Data for both filters in loaded.

EXPECTED RESULT
1. Data for only specified filter should be loaded.

SOFTWARE/OS VERSIONS
Operating System: EndeavourOS 
KDE Plasma Version: 5.27.4
KDE Frameworks Version: 5.105.0
Qt Version: 5.15.9
Kernel Version: 6.3.0-arch1-1 (64-bit)
Graphics Platform: Wayland
Processors: 16 × AMD Ryzen 7 6800HS with Radeon Graphics
Memory: 14.9 GiB of RAM
Graphics Processor: AMD Radeon Graphics
Manufacturer: ASUSTeK COMPUTER INC.
Product Name: ROG Flow X13 GV301RA_GV301RA
System Version: 1.0

ADDITIONAL INFORMATION
See video
Comment 1 Joshua Goins 2023-05-01 16:50:35 UTC
Confirmed as this has been happening to me as well
Comment 2 Bug Janitor Service 2023-09-11 20:00:18 UTC
A possibly relevant merge request was started @ https://invent.kde.org/network/tokodon/-/merge_requests/359
Comment 3 Carl Schwan 2023-09-13 12:25:36 UTC
Git commit a92b15ac01b38a82bf5abda47fde0ae458673889 by Carl Schwan, on behalf of Joshua Goins.
Committed on 13/09/2023 at 12:58.
Pushed by redstrate into branch 'master'.

Prevent messing with the notification filter controls during loading

This prevents you from interrupting and starting network requests
randomly, which could desync what's displayed and the actual network
state.

M  +1    -0    src/content/ui/NotificationPage.qml

https://invent.kde.org/network/tokodon/-/commit/a92b15ac01b38a82bf5abda47fde0ae458673889