Bug 469154

Summary: Application shouldnt force the style to the desktop style
Product: [Applications] Elisa Reporter: Adam Pigg <adam>
Component: generalAssignee: Matthieu Gallien <matthieu_gallien>
Status: RESOLVED FIXED    
Severity: wishlist CC: nate
Priority: NOR    
Version First Reported In: 23.04.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/multimedia/elisa/commit/f6d75d5ed52a322982ee85401db5b873734d3190 Version Fixed/Implemented In: 23.04.1
Sentry Crash Report:

Description Adam Pigg 2023-04-29 19:44:16 UTC 
main.cpp forces the style to org.kde.desktop.  This should be handled by the environment, and especially on a mobile device, the desktop style isnt very good, and breeze works better.

SOFTWARE/OS VERSIONS
SailflishOS: 4.5.0.19
KDE Plasma Version: N/A
KDE Frameworks Version: 105
Qt Version: 5.15

ADDITIONAL INFO
We package elisa for sailfishos here https://github.com/sailfishos-chum/elisa and patch out the setStyle calls.
Comment 1 Nate Graham 2023-05-02 16:15:43 UTC 
It's an unfortunate issue. When we didn't do this in the past, we got bug reports from the opposite direction, saying that people had the wrong style because their environment *didn't* set things up properly. We could say, "oh, that's a problem with your environment" but then it gets into the technical weeds and people just want the app to work properly without having to become experts in Qt-style theming and platform integration.

Perhaps we can do what NeoChat does and set the theming internally unless the QT_QUICK_CONTROLS_STYLE environment variable is set to something else.
Comment 2 Bug Janitor Service 2023-05-02 16:22:15 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/456
Comment 3 Nate Graham 2023-05-02 17:00:49 UTC 
Git commit 45f05eedf144b8a3a6d27065061dececc6490b4d by Nate Graham.
Committed on 02/05/2023 at 16:50.
Pushed by ngraham into branch 'master'.

Set more sensible default styles, and respect environment overrides
FIXED-IN: 23.04.1

M  +10   -4    src/main.cpp

https://invent.kde.org/multimedia/elisa/commit/45f05eedf144b8a3a6d27065061dececc6490b4d
Comment 4 Nate Graham 2023-05-02 17:02:48 UTC 
Git commit f6d75d5ed52a322982ee85401db5b873734d3190 by Nate Graham.
Committed on 02/05/2023 at 17:02.
Pushed by ngraham into branch 'release/23.04'.

Set more sensible default styles, and respect environment overrides
FIXED-IN: 23.04.1


(cherry picked from commit 45f05eedf144b8a3a6d27065061dececc6490b4d)

M  +10   -4    src/main.cpp

https://invent.kde.org/multimedia/elisa/commit/f6d75d5ed52a322982ee85401db5b873734d3190