Bug 469078

Summary: KCoreAddons does not build on macOS
Product: [Frameworks and Libraries] frameworks-kcoreaddons Reporter: Mikaela Szekely <mikaela.szekely>
Component: generalAssignee: Michael Pyne <mpyne>
Status: RESOLVED FIXED    
Severity: normal CC: kdelibs-bugs-null, mikaela.szekely, nicolas.fella
Priority: NOR    
Version First Reported In: 5.105.0   
Target Milestone: ---   
Platform: Compiled Sources   
OS: macOS   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: The full output of `cmake -B build && cmake --build build` on my macOS system

Description Mikaela Szekely 2023-04-27 20:51:24 UTC 
Created attachment 158498 [details]
The full output of `cmake -B build && cmake --build build` on my macOS system

SUMMARY

KCoreAddons uses the `SOCK_CLOEXEC` flag, which is Linux-specific and not available on macOS, causing compilation for macOS to fail with `use of undeclared identifier: 'SOCK_CLOEXEC'` in src/lib/util/ksignalhandler.cpp.


STEPS TO REPRODUCE
1. Clone https://invent.kde.org/frameworks/kcoreaddons
2. Run `cmake -B build`
3. Run `cmake --build build`

OBSERVED RESULT
Build fails with:
/Users/qyriad/code/builds/kcoreaddons/src/lib/util/ksignalhandler.cpp:37:45: error: use of undeclared identifier 'SOCK_CLOEXEC'
    if (::socketpair(AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0, KSignalHandlerPrivate::signalFd)) {



EXPECTED RESULT
Build completes successfully without error.

SOFTWARE/OS VERSIONS
macOS: 13.3.1 (x86_64)
KDE Frameworks Version: master, or 5.105.0
Qt Version: Qt6 and Qt5 both have the same result
Comment 1 Nicolas Fella 2023-05-14 12:08:09 UTC 
Fixed with https://invent.kde.org/frameworks/kcoreaddons/-/merge_requests/341