Bug 468977

Summary: Extra large icon in sidebar with specifically crafted message
Product: [Applications] NeoChat Reporter: Justin Zobel <justin.zobel>
Component: GeneralAssignee: Tobias Fella <fella>
Status: RESOLVED FIXED    
Severity: normal CC: carl
Priority: NOR    
Version First Reported In: 23.04.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Screenshot

Description Justin Zobel 2023-04-26 01:27:21 UTC
Created attachment 158427 [details]
Screenshot

Message content

{
    "content": {
        "body": "Today’s post on Akademy’s channels about e-banners
\"\"
Are you coming to #Akademy2023? Show your excitement by using one of our e-Banners on your social media, blog, or website!
https://akademy.kde.org/2023/e-banners/\nAnd if you haven't registered yet, what are you waiting for? Sign up today!
https://akademy.kde.org/2023/register/
\"\"",
        "format": "org.matrix.custom.html",
        "formatted_body": "Today’s post on Akademy’s channels about e-banners
&quot;&quot;
Are you coming to #Akademy2023? Show your excitement by using one of our e-Banners on your social media, blog, or website!
https://akademy.kde.org/2023/e-banners/<br />\nAnd if you haven't registered yet, what are you waiting for? Sign up today!
https://akademy.kde.org/2023/register/
&quot;&quot;",
        "msgtype": "m.text"
    },
    "event_id": "$fcXDV3YHYmtkRKoUglXIrRKrlperpkXDAn_3LsCYO58",
    "origin_server_ts": 1682423825043,
    "sender": "@aniqakhokhar:kde.org",
    "type": "m.room.message",
    "unsigned": {
        "m.relations": {
            "m.replace": "$DkEl81Ozad9KxR_vf5gzkCHDHeg7fw5PtGqAEN8xD8c"
        }
    }
}
Comment 1 Bug Janitor Service 2023-04-28 00:44:01 UTC
A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/936
Comment 2 Tobias Fella 2023-04-28 14:01:51 UTC
Git commit 2b06679be667bee8107b5d0581cb88ede63f2e04 by Tobias Fella.
Committed on 28/04/2023 at 13:47.
Pushed by tfella into branch 'master'.

Fix handling line separators

M  +9    -0    autotests/texthandlertest.cpp
M  +1    -0    src/texthandler.cpp

https://invent.kde.org/network/neochat/commit/2b06679be667bee8107b5d0581cb88ede63f2e04
Comment 3 Tobias Fella 2023-04-29 13:41:55 UTC
Git commit 40358cba852618dfe363dc41dc063fdeaea7310f by Tobias Fella.
Committed on 29/04/2023 at 13:41.
Pushed by tfella into branch 'release/23.04'.

Fix handling line separators
(cherry picked from commit 2b06679be667bee8107b5d0581cb88ede63f2e04)

M  +10   -0    autotests/texthandlertest.cpp
M  +1    -0    src/texthandler.cpp

https://invent.kde.org/network/neochat/commit/40358cba852618dfe363dc41dc063fdeaea7310f