Bug 468812

Summary:	Dependency on KQuickCharts not specified in CMakeLists.txt
Product:	[Applications] Arianna	Reporter:	Tom Hall <tahall256>
Component:	general	Assignee:	Carl Schwan <carl>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	1.0.0
Target Milestone:	---
Platform:	NixOS
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/arianna/commit/d3c23509c7d17191b4af1ad9f6b870fa3e944ff3	Version Fixed/Implemented In:
Sentry Crash Report:

Description Tom Hall 2023-04-22 12:56:02 UTC

SUMMARY
Arianna has a non-optional dependency on the KQuickCharts qml components, but the dependency isn't specified in CMakeLists.txt 

STEPS TO REPRODUCE
1. Build and install arianna on a system without kquickcharts installed (or in a container/sandbox if that's more convenient)
2. From a terminal on the same system, run 'arianna'.

OBSERVED RESULT
Arianna fails to run, showing the following messages in the terminal:
QQmlApplicationEngine failed to load component
qrc:/content/ui/main.qml:31:22: Type LibraryPage unavailable
qrc:/content/ui/LibraryPage.qml:10:1: module "org.kde.quickcharts" is not installed

EXPECTED RESULT
At build time, CMake complains that it can't find KQuickCharts (REQUIRED dependency, presumably, since arianna won't run without it)

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: NixOS
(available in About System)
KDE Plasma Version: 5.27.3
KDE Frameworks Version: 5.98.0
Qt Version: 5.15.8

ADDITIONAL INFORMATION

Comment 1 Carl Schwan 2023-04-23 12:48:46 UTC

Git commit d3c23509c7d17191b4af1ad9f6b870fa3e944ff3 by Carl Schwan.
Committed on 23/04/2023 at 12:48.
Pushed by carlschwan into branch 'master'.

Fix KQuickCharts missing from cmake file

M  +1    -1    CMakeLists.txt

https://invent.kde.org/graphics/arianna/commit/d3c23509c7d17191b4af1ad9f6b870fa3e944ff3