Bug 468808

Summary: flatpak-kcm bus sections have several problems
Product: [Applications] systemsettings Reporter: SolidTemperature0 <i6icgp6>
Component: kcm_flatpakAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: joshiesuhaas0, me
Priority: NOR    
Version First Reported In: 5.27.4   
Target Milestone: ---   
Platform: Manjaro   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 5.27.5
Sentry Crash Report:

Description SolidTemperature0 2023-04-22 12:25:50 UTC 
SUMMARY
flatpak-kcm bus sections (the sessions and the system ones) have multiple problems:
1. You cannot remove or delete the entries already present, only add more.
2. The type of permission (talks, owns, etc.) is not shown in the combobox, that appears empty instead.
2b. Probably adopt the same design as flatseal would be better, with a different list for each kind of permission.
3. Session bus list is bugged: it does show the string "all the system configuration" (the string may be different, because I'm translating it) instead of the actual name of the bus.



STEPS TO REPRODUCE
1. Open flatpak-kcm
2. Select any installed flatpak program


SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux 
KDE Plasma Version: 5.27.4
KDE Frameworks Version: 5.104.0
Qt Version: 5.15.8
Kernel Version: 6.2.10-1-MANJARO (64-bit)
Flatpak Version:  1:1.15.4-1
Comment 1 ratijas 2023-04-22 22:22:08 UTC 
Bus sections in 5.27.4 indeed used to have those problems. Luckily, all of those are fixed on master, and going to hit a release with 5.27.5.

> Probably adopt the same design as flatseal

Probably not, sorry. I see FlatSeal's design as needlessly restrictive. Why not allowing a user to change the policy after creation of an entry? What if you want to change the policy of an existing one to be less permissive? IMHO that doesn't make such sense.

> Session bus list is bugged: it does show the string "all the system configuration" (the string may be different, because I'm translating it) instead of the actual name of the bus.

That was an accident of not clearing the semi-global description string variable and re-using it for one of D-Bus sections instead of a service name.  See https://invent.kde.org/plasma/flatpak-kcm/-/commit/8ea7a556df6bdf8736d556a259dd45611eecf319