| Summary: | Memory leak when pasting files in administrator mode | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] kio-admin | Reporter: | Jaime Antonio Gonzalez <enigma1052666> |
| Component: | general | Assignee: | Unassigned bugs <unassigned-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | dolphin-bugs-null, meven29, nate, sitter |
| Priority: | NOR | ||
| Version First Reported In: | 23.03.90 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/frameworks/kio/commit/ae4af4ab84588f1d64149ba05d83bcb39fe84f7a | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Jaime Antonio Gonzalez
2023-04-19 06:03:44 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/1256 A possibly relevant merge request was started @ https://invent.kde.org/system/kio-admin/-/merge_requests/7 Git commit ba2468e30cb60bd3cb7353396ff3ad938e16ddf0 by Harald Sitter. Committed on 21/04/2023 at 14:42. Pushed by sitter into branch 'master'. add support for killing commands early this forwards wasKilled to the command objects and prevents us from (e.g.) reading excessive amounts of data into memory when the data is not going to be used in the client because they were only interested in the mimetype. M +20 -0 src/helper/busobject.cpp M +9 -0 src/helper/busobject.h M +5 -0 src/helper/getcommand.cpp M +3 -0 src/helper/getcommand.h M +5 -0 src/helper/listdircommand.cpp M +1 -0 src/helper/listdircommand.h M +5 -0 src/helper/putcommand.cpp M +1 -0 src/helper/putcommand.h M +63 -16 src/worker.cpp https://invent.kde.org/system/kio-admin/commit/ba2468e30cb60bd3cb7353396ff3ad938e16ddf0 A possibly relevant merge request was started @ https://invent.kde.org/system/kio-admin/-/merge_requests/8 Git commit 97637fca3ffec9924fdaf97659583688f90643c5 by Harald Sitter. Committed on 21/04/2023 at 14:43. Pushed by sitter into branch 'release/23.04'. add support for killing commands early this forwards wasKilled to the command objects and prevents us from (e.g.) reading excessive amounts of data into memory when the data is not going to be used in the client because they were only interested in the mimetype. (cherry picked from commit ba2468e30cb60bd3cb7353396ff3ad938e16ddf0) M +20 -0 src/helper/busobject.cpp M +9 -0 src/helper/busobject.h M +5 -0 src/helper/getcommand.cpp M +3 -0 src/helper/getcommand.h M +5 -0 src/helper/listdircommand.cpp M +1 -0 src/helper/listdircommand.h M +5 -0 src/helper/putcommand.cpp M +1 -0 src/helper/putcommand.h M +63 -16 src/worker.cpp https://invent.kde.org/system/kio-admin/commit/97637fca3ffec9924fdaf97659583688f90643c5 A possibly relevant merge request was started @ https://invent.kde.org/system/kio-admin/-/merge_requests/9 Git commit ae4af4ab84588f1d64149ba05d83bcb39fe84f7a by Harald Sitter. Committed on 22/04/2023 at 14:53. Pushed by meven into branch 'master'. delete threaded workers on a thread this prevents potential deadlocks between the worker thread and the main thread in case the former relies on the latter to do work. specifically qdbus seems unhappy if we wait in the main thread. in point of fact we shouldn't be waiting in the main thread anyway since the result of the thread is immaterial (wait is also called inside the workerthread destructor, I'm leaving it there as a safe guard against deleting still-running threads) M +14 -0 src/core/worker.cpp https://invent.kde.org/frameworks/kio/commit/ae4af4ab84588f1d64149ba05d83bcb39fe84f7a |