Bug 468651

Summary: Bundled QXlsx headers are used when building against system QXlsx
Product: [Applications] LabPlot2 Reporter: Antonio Rojas <arojas>
Component: generalAssignee: Alexander Semke <alexander.semke>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: 2.10.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/education/labplot/commit/36d387eec2a29d04972ff70b69483aa27675e48a Version Fixed/Implemented In:
Sentry Crash Report:

Description Antonio Rojas 2023-04-18 13:57:38 UTC 
Labplot is using the bundled QXlsx headers unconditionally, even when system QXlsx is detected and linked to:

https://invent.kde.org/education/labplot/-/blob/2.10.0/src/backend/datasources/filters/ExcelFilter.h?ref_type=tags#L19

This is wrong, the system and bundled versions of QXlsx may not be 100% compatible which would lead to crashes or other subtle errors. When building against system QXlsx, headers should be read from QXLSX_INCLUDE_DIR
Comment 1 Bug Janitor Service 2023-04-18 19:31:11 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/education/labplot/-/merge_requests/271
Comment 2 Antonio Rojas 2023-04-18 21:36:19 UTC 
Git commit 368837fa72b046a5ff33ae2842ee2a5362f5b4a3 by Antonio Rojas.
Committed on 18/04/2023 at 19:27.
Pushed by sgerlach into branch 'master'.

Use system QXlsx headers if building against system QXlsx

When building against the system QXlsx the system headers should be used instead of hardcoding the bundled ones

M  +5    -0    src/CMakeLists.txt
M  +3    -3    src/backend/datasources/filters/ExcelFilter.h
M  +1    -1    src/kdefrontend/datasources/ExcelOptionsWidget.cpp

https://invent.kde.org/education/labplot/commit/368837fa72b046a5ff33ae2842ee2a5362f5b4a3
Comment 3 Stefan Gerlach 2023-04-18 21:37:30 UTC 
Git commit 36d387eec2a29d04972ff70b69483aa27675e48a by Stefan Gerlach, on behalf of Antonio Rojas.
Committed on 18/04/2023 at 21:37.
Pushed by sgerlach into branch 'release/2.10'.

Use system QXlsx headers if building against system QXlsx

When building against the system QXlsx the system headers should be used instead of hardcoding the bundled ones

M  +5    -0    src/CMakeLists.txt
M  +3    -3    src/backend/datasources/filters/ExcelFilter.h
M  +1    -1    src/kdefrontend/datasources/ExcelOptionsWidget.cpp

https://invent.kde.org/education/labplot/commit/36d387eec2a29d04972ff70b69483aa27675e48a